Filter is not working to exclude actions from undo/redo history

[dmathisen]

I'm submitting a ...

• Bug report
• Feature request
• Docs update
• Support request => Please do not submit support requests here, see note at the top of this template.

What is the current behavior/state of the project?

The filter property seems to be broken.

What is the desired behavior?

Reducers listed in the filter array should be ignored from undo/redo history.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via a gist or similar.

Reproduceable in this CodeSandbox.
In this example, the 2nd number has a filter to exclude the action (see store.ts filter: excludeAction(["increment2", "decrement2"])). So I would expect the 2nd number to NOT be affected by undo/redo, but it is.

Please tell us about your environment:

• Library version: 1.1.0
• Redux version: 8.1.2
• Browser: all
• Language: TypeScript 5.1.6

Note: there's a (maybe) related issue filed a long time ago and it says that the issue may have been introduced in 1.0.0-beta8, but I haven't been able to verify.

[kartGRAM]

Isn't there an error in the following section, and shouldn't it be like this instead?
excludeAction(["counter/increment2", "counter/decrement2"])
https://codesandbox.io/p/sandbox/rtk-redux-undo-example-forked-6h6gwh

[dmathisen]

@kartGRAM Perhaps, but clicking UNDO in your example still undoes the increment2/decrement2 actions, so it's still not working.

EDIT: The behavior is odd. If I only do the increment2/decrement2 actions, it doesn't undo. But then I do increment1/decrement1 and when I click UNDO, increment2/decrement2 resets to 0. Maybe it's just a bug in my code example. I'll dig in more. But I think your solution could be correct.

[chenzhutian]

I also have the similar bug