Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer Dependency issues with React18 #683

Open
1 task done
prantikseal opened this issue Mar 6, 2024 · 2 comments
Open
1 task done

Peer Dependency issues with React18 #683

prantikseal opened this issue Mar 6, 2024 · 2 comments

Comments

@prantikseal
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

should install on npm i

Current Behavior

image

Steps to Reproduce (for bugs)

  1. install react 18 (latest)
  2. install react-swipeable-views

Context

Your Environment

Tech Version
react-swipeable-views 0.14.0
React 18
platform VS code
etc
@PatrickMA
Copy link

Use npm i react-swipeable-views --legacy-peer-deps.

@ricardasjak
Copy link

ricardasjak commented Aug 21, 2024 •
edited
Loading

This is hardly acceptable solution, we have to change whole CI pipeline to enforce --legacy-peer-deps flag for npm ci and npm i commands, change documentation for running project, seems like very undesirable workaround to handle single dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ricardasjak @PatrickMA @prantikseal