Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add option to exclude per consumer stream metrics #902

Closed
1 of 2 tasks
nantiferov opened this issue May 10, 2024 · 1 comment · Fixed by #906
Closed
1 of 2 tasks

Feature: Add option to exclude per consumer stream metrics #902

nantiferov opened this issue May 10, 2024 · 1 comment · Fixed by #906
Assignees
Labels

Comments

@nantiferov
Copy link
Contributor

nantiferov commented May 10, 2024

Describe the problem
Hi,

I noticed that with enabling existing check-streams / check-single-streams options exporter fetches quite a lot of metrics per each consumer. As a result, it creates additional load on TSDB and I'm not sure these metrics will be useful.

However, I find group/stream level metrics quite useful. What do you think about adding one more option to skip adding consumer level metrics for streams (default disabled to keep current behaviour)?

I can prepare PR with implementation.

What version of redis_exporter are you running?
Please run redis_exporter --version if you're not sure what version you're running.

  • 0.3x.x
  • 1.x.x

Running the exporter
What's the full command you're using to run the exporter? (please remove passwords and other sensitive data)
Please include details about env variables, command line parameters, your orchestration setup, etc.

Screenshots
If applicable, add screenshots to help explain your question.

Additional context
Add any other context about the question here.

@oliver006
Copy link
Owner

I think that's a great idea!
Happy to review a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants