Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kmeans-colors to Scoop Extras #61

Open
oxjihun opened this issue Dec 17, 2024 · 3 comments
Open

Add kmeans-colors to Scoop Extras #61

oxjihun opened this issue Dec 17, 2024 · 3 comments

Comments

@oxjihun
Copy link

oxjihun commented Dec 17, 2024

Scoop is a command-line installer for Windows. I wrote a following manifest that, once added to any of the Scoop's buckets such as Extras, would enable installing kmeans-colors via scoop install kmeans-colors.

{
    "version": "0.6.0",
    "description": "k-means clustering library and binary to find dominant colors in images",
    "homepage": "https://github.com/okaneco/kmeans-colors",
    "license": "MIT",
    "architecture": {
        "64bit": {
            "url": "https://github.com/okaneco/kmeans-colors/releases/download/0.6.0-binary/kmeans_colors-0.6.0-binary-windows-x86_64.tar.gz",
            "hash": "0d9060a8af1ebe19812618760b8e9f1f7907d925e523085b1a68d0ba9bcaa270"
        }
    },
    "bin": "kmeans_colors.exe",
    "checkver": "github",
    "autoupdate": {
        "architecture": {
            "64bit": {
                "url": "https://github.com/okaneco/kmeans-colors/releases/download/$version-binary/kmeans_colors-$version-binary-windows-x86_64.tar.gz",
                "hash": {
                    "url": "https://github.com/okaneco/kmeans-colors/releases/download/$version-binary/kmeans_colors-$version-binary-windows-x86_64.sha256"
                }
            }
        }
    }
}

I am writing this issue to learn about how you might feel about this before actually making a PR there!

@okaneco
Copy link
Owner

okaneco commented Dec 18, 2024

Thanks, I just have one question about this.

When I update to a new major version like 0.7.0 or 1.0, will the autoupdate tag pick up that as the new base version? Or will that require a manual update of the manifest to the next version?

Otherwise, I'm generally in favor of letting more people use the tool if they find it helpful and the burden of maintenance seems minimal for me.

@oxjihun
Copy link
Author

oxjihun commented Dec 19, 2024

Yes, Scoop buckets have GitHub Actions that check for new versions (0.7.0 or 1.0 would be correctly recognized as newer than 0.6.0) and apply automatic updates to manifests according to the autoupdate fields. Manual updates would be needed only when new binaries are available or when there are alterations in naming schemes etc., but not for when new versions are released.

Thanks for positively responding, I will leave comments about how things go!

@oxjihun
Copy link
Author

oxjihun commented Dec 23, 2024

Ongoing PR: ScoopInstaller/Extras#14624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants