Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup to notification DM issue PR #2398

Open
taoeffect opened this issue Oct 28, 2024 · 0 comments
Open

Followup to notification DM issue PR #2398

taoeffect opened this issue Oct 28, 2024 · 0 comments
Assignees
@corrideat
Labels
App:Frontend Kind:Bug Priority:High

Comments

@taoeffect
Copy link
Member

Problem

As explained in this comment, I merged #2394 when I shouldn't have.

Solution

The isTargetChatroomCurrentlyActive check should either be done inside of messageReceivePostEffect or passed in as a boolean to messageReceivePostEffect, so that 'gi.actions/identity/kv/addChatRoomUnreadMessage' always gets called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corrideat corrideat

Labels
App:Frontend Kind:Bug Priority:High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taoeffect @corrideat