Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify layer as Key Map does not save succesfully #178

Open
rchampine opened this issue Feb 21, 2024 · 14 comments · Fixed by #180
Open

Classify layer as Key Map does not save succesfully #178

rchampine opened this issue Feb 21, 2024 · 14 comments · Fixed by #180
Labels
bug Something isn't working

Comments

@rchampine
Copy link

I'm not sure if this is just on this map or others as well, but the Classify Layers function is not behaving correctly for saving a Key Map. It appears to work, but upon refreshing or opening up a georeferencing session, the classified sheet reverts back to Main Content.

Screen.Recording.2024-02-21.at.10.40.24.AM.mov
@rchampine rchampine added the bug Something isn't working label Feb 21, 2024
@mradamcox
Copy link
Collaborator

Thanks @rchampine, I think I see the problem, should be able to deploy a fix later tonight (as well as some a few other updates).

@rchampine
Copy link
Author

Great — thank you!

@rchampine
Copy link
Author

Looks like this issue or a very similar issue is cropping up again.

ClassifyLayers.mov

@rchampine
Copy link
Author

Additional example on this Philadelphia volume where a map is "stuck" as classified as a Key map: https://oldinsurancemaps.net/resource/32830
image

@mradamcox
Copy link
Collaborator

mradamcox commented Apr 24, 2024

Weirdly, I was able to just go in and classify this one properly right now. There must be some intermittent issue having to do with the state of the page. Definitely warrants investigation.
I wonder if a full page reload is needed in between classification/reclassification of the same item?

@mradamcox mradamcox reopened this Apr 24, 2024
@rchampine
Copy link
Author

Interesting... I'm having no luck with reloading and classifying on either of these volumes:
https://oldinsurancemaps.net/map/sanborn04023_022
https://oldinsurancemaps.net/map/sanborn06671_013

@mradamcox
Copy link
Collaborator

Huh, and again, worked fine for me. Things are a little jumpy sometimes though, like I set to Key Map and it flashed back a forth once or twice and then settles. One thing to note is that the save happens immediately on the dropdown change, not when the Done button is clicked. At any rate, will look further soon.

@rchampine
Copy link
Author

This volume is also experiencing the bug for both Nate and I — https://oldinsurancemaps.net/map/sanborn09345_008

@mradamcox
Copy link
Collaborator

So strange. At first it didn't work for me and now it just did. At any rate, I've reworked this classification process a bit locally, just haven't been able to deploy the changes yet. Perhaps tonight or early tomorrow morning.

@rchampine
Copy link
Author

Great — thank you!

@mradamcox
Copy link
Collaborator

Ok, I've reworked the process a bit, so the Save/Cancel buttons are implemented again, and the logic that handles the process is a bit cleaner. I think this particular issue should be addressed, though there are still some details to come back to.

@rchampine
Copy link
Author

Is this implemented publicly? I'm still seeing the same behavior/bug as before.

@mradamcox
Copy link
Collaborator

🤦 Ok now it is.

@rchampine
Copy link
Author

Yes! Haha thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants