Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field validation to resolve the Update Profile Issue #8809

Merged
merged 21 commits into from
Oct 23, 2024
Merged

Add field validation to resolve the Update Profile Issue #8809

merged 21 commits into from
Oct 23, 2024

Conversation

JavidSumra
Copy link
Contributor

Proposed Changes

This PR introduces logic to disable the "Update" button on the profile update page when no changes are detected in the form fields. The useMemo hook compares the current form values with the user's existing data and detects any modifications.

@ohcnetwork/care-fe-code-reviewers

Demo Video

Click here to watch the demo video

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@JavidSumra JavidSumra requested a review from a team as a code owner October 17, 2024 03:51
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 5efa3cd
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6718f0e908291600083452e0
😎 Deploy Preview https://deploy-preview-8809--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bodhish
bodhish requested changes Oct 17, 2024
View reviewed changes
src/Components/Users/UserProfile.tsx Outdated Show resolved Hide resolved
rithviknishad
rithviknishad requested changes Oct 17, 2024
View reviewed changes
src/Components/Users/UserProfile.tsx Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

@JavidSumra fix the failing cypress test

@JavidSumra
Copy link
Contributor Author

JavidSumra commented Oct 19, 2024 •
edited
Loading

@JavidSumra fix the failing cypress test

Hi @nihal467 Sir, I ran all the test cases locally, and only one test case from the users_spec suite, which passed in the workflow tests. However, all the other test cases that are failing in the workflow have passed locally. I believe the issue might be related to a timeout. What should I do next?

Test Cases Result Video

@bodhish
Copy link
Member

bodhish commented Oct 21, 2024

@nihal467 the failing specs are majorly not related to this PR. Do check it out.

@github-actions GitHub Actions
Copy link

👋 Hi, @JavidSumra,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 22, 2024
@JavidSumra
Copy link
Contributor Author

Hey @nihal467 can you please check updates in test cases now it's passing all the test cases.

@rithviknishad rithviknishad added needs testing and removed test failed changes required merge conflict pull requests with merge conflict labels Oct 22, 2024
@JavidSumra
Copy link
Contributor Author

Hey @nihal467 can you please help me to debug why test cases are failing so I can fix Accordingly

@JavidSumra
Copy link
Contributor Author

JavidSumra commented Oct 23, 2024 •
edited
Loading

Thanks @nihal467 all the test cases passed now!!
cc @bodhish

@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 23, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @JavidSumra,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 23, 2024
bodhish
bodhish approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish bodhish merged commit ed3c32a into ohcnetwork:develop Oct 23, 2024
22 of 23 checks passed
@github-actions GitHub Actions
Copy link

@JavidSumra Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@JavidSumra
Copy link
Contributor Author

Hey @bodhish can you please assign 2 story point for this?

@bodhish
Copy link
Member

bodhish commented Oct 23, 2024

Done

noufalrahim pushed a commit to noufalrahim/care_fe that referenced this pull request Oct 24, 2024
@JavidSumra @noufalrahim
Add field validation to resolve the Update Profile Issue (ohcnetwork#…
c51b88b 
…8809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish bodhish approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary API Call on Profile Update Without Changes
4 participants
@JavidSumra @nihal467 @bodhish @rithviknishad