feat/Added bed number in location card (#8131) #8677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Comment on lines
+78
to
+90
| function BedsData(facilityId: string, locationId: string) { | ||
| const { loading, data } = useQuery(routes.listFacilityBeds, { | ||
| query: { | ||
| facility: facilityId, | ||
| location: locationId, | ||
| }, | ||
| }); | ||
|
|
||
| return { | ||
| loading, | ||
| totalBeds: data?.results.length || 0, | ||
| }; | ||
| } |
There was a problem hiding this comment.
let's not create a function that wraps a hook
| @@ -216,6 +242,7 @@ export default function LocationManagement({ facilityId }: Props) { | |||
| const Location = ({ | |||
There was a problem hiding this comment.
Instead call that hook inside this component without wrapping
Comment on lines
+132
to
+153
| {(item) => { | ||
| const { loading, totalBeds } = BedsData(facilityId, item.id); | ||
|
|
||
| if (loading) { | ||
| return <Loading />; | ||
| } | ||
| return ( | ||
| <Location | ||
| setShowDeletePopup={setShowDeletePopup} | ||
| facilityId={facilityId} | ||
| {...item} | ||
| totalBeds={totalBeds} | ||
| disabled={ | ||
| ["DistrictAdmin", "StateAdmin"].includes( | ||
| authUser.user_type, | ||
| ) | ||
| ? false | ||
| : true | ||
| } | ||
| /> | ||
| ); | ||
| }} |
There was a problem hiding this comment.
That way these changes also can be reverted
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist