Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Community Nurse's Log; improved Nursing Care section UI #8522

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Adds Community Nurse's Log; improved Nursing Care section UI #8522

wants to merge 8 commits into from
+609 −185

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 11, 2024 •
edited
Loading

Required Backend Changes

Proposed Changes

1. Improved Nursing Care UX

Use the multi-select menu to select all of the relevant nursing care procedures to be filed, and then add remarks for each of the nursing care procedures.

image image

2. Adds support for filing Community Nurse's log update

image

3. Hide's details from Log Update details page if section/data is not filled.

image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@netlify Netlify
Copy link

netlify bot commented Sep 11, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 08cc4d9
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66e46197fb67f90008c379c9
😎 Deploy Preview https://deploy-preview-8522--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Sep 11, 2024
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Sep 11, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 11, 2024 •
edited
Loading

CARE    Run #3339

Run Properties:  status check failed Failed #3339  •  git commit 08cc4d9dd1: Adds Community Nurse's Log; improved Nursing Care section UI
Project CARE
Branch Review rithviknishad/feat/community-nurses-log-update
Run status status check failed Failed #3339
Run duration 06m 45s
Commit git commit 08cc4d9dd1: Adds Community Nurse's Log; improved Nursing Care section UI
Committer Rithvik Nishad
View all properties for this run ↗︎
Test results
Tests that failed  Failures 6
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 122
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/patient_spec/patient_logupdate.cy.ts • 6 failed tests • UI-Chrome

View Output

Test Artifacts
Patient Log Update in Normal, Critical and TeleIcu > Create a basic critical care log update for a admitted patient and edit it Test Replay Screenshots
Patient Log Update in Normal, Critical and TeleIcu > Create a new Progress log update for a admitted patient and edit it Test Replay Screenshots
Patient Log Update in Normal, Critical and TeleIcu > Create a new TeleIcu log update for a domicilary care patient Test Replay Screenshots
Patient Log Update in Normal, Critical and TeleIcu > Create a new Normal Log update for a domicilary care patient and edit it Test Replay Screenshots
Patient Log Update in Normal, Critical and TeleIcu > Create a new Normal update for a admission patient and verify its reflection in cards Test Replay Screenshots
Patient Log Update in Normal, Critical and TeleIcu > Create a Normal Log update to verify MEWS Score Functionality Test Replay Screenshots

@rithviknishad rithviknishad mentioned this pull request Sep 13, 2024
Open
3 tasks
@rithviknishad rithviknishad marked this pull request as ready for review September 13, 2024 08:43
@rithviknishad rithviknishad requested a review from a team as a code owner September 13, 2024 08:43
@nihal467
Copy link
Member

nihal467 commented Sep 13, 2024 •
edited
Loading

  • creation
  • updation
  • edit
  • view in charts
  • view in details page
  • events log

@nihal467
Copy link
Member

nihal467 commented Sep 13, 2024 •
edited by rithviknishad
Loading

Bug

image

  • the dropdowns are not properly responsive

image
image

  • in the view details page, the neurological monitor table are shown, which are not being recorded, so show only relevant and recorded details in this page
  • similarly hide the pain scale and pressure sore too

image
image

  • when you click update log button, it is been redirected to a irrelevant page, the user should be able to view the form directly

image

  • nursing care without remarks are hidden in the view details page

image

  • fix the typo error for the log update notification and post submission redirection

image

  • the patient category details in missing in this page

  • the newly added fields have no reflection across the patient consultation page, over any cards,

Enhancement

  • only show oral issue, if the user select nutrition route as oral, otherwise hide it

@rithviknishad rithviknishad mentioned this pull request Sep 13, 2024
Open
@rithviknishad
FIxes issues reported in QA
08cc4d9 
* Fixes form responsiveness in mobile displays
* Fixes bugs in view details page
* Fixes update log redirection
* Fixes #8534 - Show patient category
@nihal467
Copy link
Member

nihal467 commented Sep 16, 2024 •
edited
Loading

LGTM , conditionally approving this PR as its priority, the data reflection card needs to be followed up with @aparnacoronasafe , and create a new issue for that as well @rithviknishad @khavinshankar

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 17, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Sep 17, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

@khavinshankar khavinshankar Awaiting requested review from khavinshankar

@shivankacker shivankacker Awaiting requested review from shivankacker

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict tested waiting for backend
Projects
None yet
Milestone
No milestone
2 participants
@rithviknishad @nihal467