Remove tooltip after Cover Image Load #8489
Conversation
👷 Deploy request for care-ohc pending review.Visit the deploys page to approve it
|
|
Converting back to draft as I just saw the comment about cache invalidation #8480 (comment) |
- Refresh cover image on page, right after save - Previously required page reload for changes to show up on page
| facilityFetch(); | ||
| fetchImage(); | ||
| setCoverImageEdited(true); |
There was a problem hiding this comment.
Can we wait till the fetch image is done (in the loading state itself of the image edit modal) before running facility fetch?
| {coverImageEdited && !coverImageLoaded && ( | ||
| <div className="absolute inset-x-0 bottom-0 w-full rounded-b-md bg-black/70 px-2 pb-0.5 backdrop-blur-sm"> | ||
| <span className="text-center text-xs font-medium text-secondary-100"> | ||
| {t("cover_image_updated_note")} |
There was a problem hiding this comment.
That way we can remove this tooltip altogether
| const [coverImageLoaded, setCoverImageLoaded] = useState(false); | ||
| const [coverImageUrl, setCoverImageUrl] = useState<string | undefined>(""); |
There was a problem hiding this comment.
And these unnecessay useStates too could be removed that way.
| imageUrl += "?" + Date.now(); | ||
| setCoverImageUrl(imageUrl); |
There was a problem hiding this comment.
Let's not add query params. We know for sure that it always fetches the latest image with query params present. There's no need to perform the vary header method when giving query params right.
| credentials: "include", | ||
| mode: "no-cors", |
There was a problem hiding this comment.
are these headers required? how does this differ from with and without these?
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist