Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ Fixes issue with treating physician field being disabled when a search text entered yields no results; 🛠️ Migrate UserAutocompleteFormField to use useQuery #8274

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 8, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 8:18am

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f38e0dc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66b5d0a96235450007c5cd3d
😎 Deploy Preview https://deploy-preview-8274--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad changed the title Migrate UserAutocompleteFormFIeld to useQuery Migrate UserAutocompleteFormField to use useQuery Aug 8, 2024
Copy link

cypress bot commented Aug 8, 2024



Test summary

126 0 0 0


Run details

Project CARE
Status Passed
Commit f38e0dc
Started Aug 9, 2024 8:22 AM
Ended Aug 9, 2024 8:25 AM
Duration 02:56 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 7c3601b
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66b4b50c4376910008fa12f9

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Aug 8, 2024
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Aug 8, 2024
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Aug 8, 2024
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Aug 8, 2024
@rithviknishad rithviknishad changed the title Migrate UserAutocompleteFormField to use useQuery Fixes issue with treating physician field being disabled when a search text entered yields no results; Migrate UserAutocompleteFormField to use useQuery Aug 8, 2024
@rithviknishad rithviknishad changed the title Fixes issue with treating physician field being disabled when a search text entered yields no results; Migrate UserAutocompleteFormField to use useQuery 🛠️ Fixes issue with treating physician field being disabled when a search text entered yields no results; 🛠️ Migrate UserAutocompleteFormField to use useQuery Aug 8, 2024
@rithviknishad rithviknishad marked this pull request as ready for review August 8, 2024 12:50
@rithviknishad rithviknishad requested a review from a team as a code owner August 8, 2024 12:50
@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Aug 8, 2024
@nihal467
Copy link
Member

nihal467 commented Aug 8, 2024

image

  • the user is not linked to the facility anymore, still its showing the username in the dropdown
  • can you fix the cypress issue as well

…ield' of github.com:coronasafe/care_fe into rithviknishad/useQuery-migrations/userautocompleteformfield
@khavinshankar khavinshankar merged commit 18e9888 into develop Aug 9, 2024
66 of 68 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/useQuery-migrations/userautocompleteformfield branch August 9, 2024 10:23
Copy link

github-actions bot commented Aug 9, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

treating physician dropdown in consultation form is malfunctioning
3 participants