Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds prompt for ICD11 search field #8232 #8233

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Adds prompt for ICD11 search field #8232 #8233

merged 2 commits into from
Jul 31, 2024

Conversation

ahmedobaid23
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@ahmedobaid23 ahmedobaid23 requested a review from a team as a code owner July 30, 2024 12:02
@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024

@ahmedobaid23 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d6cb6fa
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66a8e8770709f100089e6b0b
😎 Deploy Preview https://deploy-preview-8233--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmedobaid23

So the 1 character minimum requirement is not applicable for all usages of the autocomplete field. This component is used in multiple other places as well, and some usages does not even need a query text in the first place in-order to be able to show the options.

Maybe consider adding a prop minQueryLength?: number and conditionally only achieve the requirement specified in the issue.

rithviknishad
rithviknishad approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Nice work!

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit f356406 into ohcnetwork:develop Jul 31, 2024
29 of 31 checks passed
@github-actions GitHub Actions
Copy link

@ahmedobaid23 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@rithviknishad rithviknishad mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prompt for ICD11 search field
4 participants
@ahmedobaid23 @nihal467 @rithviknishad @khavinshankar