Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve strength of the caution message for potentially incorrect discharge dates #8154

Closed
wants to merge 5 commits into from
Closed

Improve strength of the caution message for potentially incorrect discharge dates #8154

wants to merge 5 commits into from

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 16, 2024 •
edited
Loading

Proposed Changes

  • Fixes Caution message on discharge pop-up #8150
  • The strength of the caution message conveyed is increased when the encounter duration based on the discharge date specified in the input would be more than 30 days.
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner July 16, 2024 05:16
@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 7:04am

@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6b6f8f7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66976cb8e48cc2000828c91e
😎 Deploy Preview https://deploy-preview-8154--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Jul 16, 2024 •
edited
Loading

Passing run #2876 ↗︎

0 126 0 0 Flakiness 0

Details:

Improve strength of the caution message for potentially incorrect discharge date...
Project: CARE Commit: 6b6f8f7d8b
Status: Passed Duration: 03:05 💡
Started: Jul 17, 2024 7:08 AM Ended: Jul 17, 2024 7:11 AM

Review all test suite changes for PR #8154 ↗︎

@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jul 16, 2024
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Jul 16, 2024
@nihal467
Copy link
Member

@rithviknishad can you revert the message to yellow and add an acknowledge pop-up asking user " Are you sure you want to discharge this patient marking ___ days of consultation " or something much more appropriate

@rithviknishad rithviknishad deleted the rithviknishad/fix/8150-discharge-encounter-duration-caution branch July 23, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihal467 nihal467 nihal467 left review comments

Assignees
No one assigned
Labels
changes required needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caution message on discharge pop-up
2 participants
@rithviknishad @nihal467