Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Error for Consultation Form #8142

Closed
nihal467 opened this issue Jul 12, 2024 · 6 comments · Fixed by ohcnetwork/care#2309
Closed

Improve the Error for Consultation Form #8142

nihal467 opened this issue Jul 12, 2024 · 6 comments · Fixed by ohcnetwork/care#2309
Assignees
Labels

Comments

@nihal467
Copy link
Member

nihal467 commented Jul 12, 2024

Describe the bug

When a doctor called "Dr A" is being unlinked from a facility and you try to edit a consultation of a patient, where the Dr A was assign, the error thrown in front is not user friendly

To Reproduce
Steps to reproduce the behavior:

  1. Go to patient consultation page of a patient
  2. Identify the treating doctor (from consultation form) and unlink the doctor from the facility (using user tab)
  3. Now try to edit the consultation form and submit it
  4. See error

Expected behavior

The error message should be modified to "Oops! The treating doctor is no longer linked to this facility. Please update the respective field in the form before proceeding. "

Screenshots

WhatsApp Image 2024-07-09 at 15 33 02_9a4b86d9

@lakshaydewan
Copy link

Hi @nihal467 ,

I'd like to be assigned to this issue. I'm interested in working on it and believe I can help resolve it.

@lakshaydewan
Copy link

lakshaydewan commented Jul 12, 2024

how do i unlink the doctor from the facility?
unlinking the Doctor shows an Error - "Facility access not present"

@nihal467
Copy link
Member Author

  • Go to user tab, by clicking on the sidebar
  • Search for the user id
  • Click linked facilities button in the respective user card
  • click the red button in the same row of the facility name , you click on that
  • You will receive a successful notification to confirm unlinking is done

@lakshaydewan lakshaydewan removed their assignment Jul 12, 2024
@shivankacker shivankacker self-assigned this Jul 12, 2024
@shivankacker
Copy link
Member

shivankacker commented Jul 14, 2024

@nihal467 adding to this, I think a user should not be able to unlink a doctor from a facility until the doctor is unassigned from all the active patients. An error should be thrown if unassigned.

cc. @gigincg

@shivankacker shivankacker added the question Further information is requested label Jul 14, 2024
@nihal467 nihal467 removed the question Further information is requested label Jul 15, 2024
@nihal467
Copy link
Member Author

@skks1212 can you push the fix as well discussed in the engineer call, modify the error message for now

Copy link

Hi, @coronasafe/care-frontend-maintainers, This issue has been automatically marked as stale because it has not had any recent activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants