Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rendering of array of strings to utilise humanizeStrings utility method #8128

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Refactor rendering of array of strings to utilise humanizeStrings utility method #8128

merged 4 commits into from
Jul 16, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner July 8, 2024 14:24
@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 7:13am

@netlify Netlify
Copy link

netlify bot commented Jul 8, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5753f5a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/668f85f77f03fd0008396d8c
😎 Deploy Preview https://deploy-preview-8128--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Jul 8, 2024 •
edited
Loading

Passing run #2846 ↗︎

0 126 0 0 Flakiness 0

Details:

Refactor rendering of array of strings to utilise `humanizeStrings` utility meth...
Project: CARE Commit: 5753f5a514
Status: Passed Duration: 03:53 💡
Started: Jul 11, 2024 7:22 AM Ended: Jul 11, 2024 7:26 AM

Review all test suite changes for PR #8128 ↗︎

@rithviknishad rithviknishad marked this pull request as draft July 8, 2024 15:04
@rithviknishad rithviknishad marked this pull request as ready for review July 10, 2024 04:14
@nihal467
Copy link
Member

All the file changes file functionality looks good to me

@khavinshankar khavinshankar merged commit 4e32402 into develop Jul 16, 2024
62 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/refactor-humanize-strings branch July 16, 2024 12:51
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Quality Improvement: Utilise the humanizeStrings utility method to format array of strings
3 participants
@rithviknishad @nihal467 @khavinshankar