Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caution for encounter date field if date is beyond 30 days. #8125

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner July 8, 2024 12:27
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 7:03am

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5c3f932
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/668f83a3f7489900097d4064
😎 Deploy Preview https://deploy-preview-8125--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jul 8, 2024

Passing run #2843 ↗︎

0 126 0 0 Flakiness 0

Details:

Add caution for encounter date field if date is beyond 30 days.
Project: CARE Commit: 5c3f9326e0
Status: Passed Duration: 03:01 💡
Started: Jul 11, 2024 7:07 AM Ended: Jul 11, 2024 7:10 AM

Review all test suite changes for PR #8125 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jul 9, 2024

@rithviknishad once the logic is fixed in #8124 , implement it here as well

@rithviknishad
Copy link
Member Author

@nihal467 The caution in the encounter date field is not shown if it's within 30 days. And for values beyond 30 days, it'll always show as a month ago and above and not the actual no. of days ago.

Hence this PR can be tested without the potential changes from #8124

@nihal467
Copy link
Member

LGTM

Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jul 11, 2024
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jul 11, 2024
@khavinshankar khavinshankar merged commit 6739c26 into develop Jul 11, 2024
61 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/8120 branch July 11, 2024 07:12
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding caution for back-dated encounter date entries when creating a consultation
3 participants