Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: Renaming patient categorisation #7811 #7820

Conversation

Sulochan-khadka
Copy link
Contributor

@Sulochan-khadka Sulochan-khadka commented May 14, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Sulochan-khadka Sulochan-khadka requested a review from a team as a code owner May 14, 2024 20:09
Copy link

vercel bot commented May 14, 2024

@Sulochan-khadka is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e8e10a6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6643c5014447f80009928cfc
😎 Deploy Preview https://deploy-preview-7820--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8ee6257
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6643c510d194e100083ae07e
😎 Deploy Preview https://deploy-preview-7820--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sulochan-khadka
Copy link
Contributor Author

@rithviknishad could you review this?

Comment on lines +386 to +387
{ id: "Mild", text: "Mild", twClass: "patient-mild" },
{ id: "Moderate", text: "Moderate", twClass: "patient-moderate" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need not change the ID' and tailwind classess. You can just change the labels (text)

Comment on lines +686 to +687
{ value: 3, text: "Moderate Flexion(decorticate)" },
{ value: 2, text: "Moderate Extension(decerebrate)" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed? Totally unrelated to patient category.

Comment on lines +82 to +83
Mild: "MILD",
Moderate: "MODERATE",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keys need not be changed. Just display text needs to be changed

@@ -24,7 +24,7 @@ export default function PatientCategorySelect(
"h-2 w-2 rounded-full",
{
Comfort: "bg-patient-comfort",
Stable: "bg-patient-stable",
Mild: "bg-patient-stable",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here too

@rithviknishad rithviknishad added invalid This doesn't seem right changes required labels May 17, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 22, 2024
Copy link

👋 Hi, @Sulochan-khadka,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad
Copy link
Member

Closing as completed in 1554ef2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required invalid This doesn't seem right merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming patient categorisation
2 participants