Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sales: product variants config btn instructions #3696

Closed

Conversation

samueljlieber
Copy link
Contributor

Issue: #3576

This PR improves the instructions to deactivate a particular product variant by making the UI accurate and the instructions clearer.

Targets 15.0 and 16.0

@robodoo
Copy link
Collaborator

robodoo commented Feb 28, 2023

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @samueljlieber
@odoo/doc-review this quick fix on a sales doc is ready for review, thank you!

@jcs-odoo
Copy link
Contributor

jcs-odoo commented Mar 1, 2023

Hi @samueljlieber :)
You can link issues and branches in their "development" section above the notifications section.
This way, the issue will be marked as solved once this PR is merged and closed.

Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the 'Exclude For' feature deprecated for Variants? If so then time to remove from docs
6 participants