Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebooks should have access to requesters oda token #158

Closed
volodymyrss opened this issue Mar 22, 2024 · 2 comments · Fixed by #168 or oda-hub/oda_api#248 · May be fixed by oda-hub/ontology#33
Closed

notebooks should have access to requesters oda token #158

volodymyrss opened this issue Mar 22, 2024 · 2 comments · Fixed by #168 or oda-hub/oda_api#248 · May be fixed by oda-hub/ontology#33
Assignees

Comments

@volodymyrss
Copy link
Member

No description provided.

@dsavchenko
Copy link
Member

dsavchenko commented Mar 27, 2024

Just realised that nb2workflow already has access to the token. In dispatcher, the token is a parameter in SourceQuery. So it ends up in the request to backend. Then it needs to be added to the notebook run, probably as an environment variable.
We may use some convention, but dedicated annotation would be preferable.

The only edge case is when the notebook declares parameter named "token". Probably needs some change in the plugin.

Also to check if token affects job hash in nb2workflow. If so, needs to be underscored.

@dsavchenko
Copy link
Member

Reopening as #168 is still not merged

@dsavchenko dsavchenko reopened this May 15, 2024
@okolo okolo linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment