Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain ontology restrictions #91

Open
Lukas113 opened this issue Mar 11, 2024 · 0 comments
Open

explain ontology restrictions #91

Lukas113 opened this issue Mar 11, 2024 · 0 comments
Assignees

Comments

@Lukas113
Copy link

Lukas113 commented Mar 11, 2024

I've looked into odahub-ontology to define parameters. There are also additional options to set something like lower_limit, upper_limit or allowed_value, which is great. With tools like that I was thinking, are these restrictions automatically set to certain ontology-items like PointOfInterestRA? In the dev-guide-doc I've found the following statement:

"""
it is possible to customize the parameter by adding annotation the input parameter with an MMODA ontology item as a comment (after the hash sign, #http://odahub.io/ontology#AngleDegrees in the reference example of the Source_region_radius parameter. This may be useful for checking the validity of the user inputs. For example, the sky angle in degrees (defined by the #http://odahub.io/ontology#AngleDegrees) should be a float number and can take values between 0 and 360.
"""

With only this, I'm not sure about the following things:

  • Is a limit & allowed-values run-time validation-check performed by oda? If yes, what are the restrictions set for each item (don't see anything in doc, so I just can make assumptions). If no, I think it's worth to say that explicitly.
  • Is a dtype run-time check performed by oda? What about coercion (e.g. int -> float). Are None-types allowed? What happens if a field is empty (NoneType, empty String, what about numeric-values)?
@volodymyrss volodymyrss self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants