Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra_ttl issue when creating instance of NB2WLightCurveProduct #111

Open
burnout87 opened this issue Sep 13, 2024 · 3 comments · May be fixed by #113
Open

extra_ttl issue when creating instance of NB2WLightCurveProduct #111

burnout87 opened this issue Sep 13, 2024 · 3 comments · May be fixed by #113
Assignees

Comments

@burnout87
Copy link
Contributor

burnout87 commented Sep 13, 2024

When completing (locally) the lightcurve notebook of jemx_expert, the following issue:

"init() got an unexpected keyword argument 'extra_ttl'"

when trying to create an instance of the class NB2WLightCurveProduct here:

if extra_ttl:
extra_kw = {'extra_ttl': extra_ttl}
try:
prod_list.extend( mapping.get(owl_type, cls)._init_as_list(output[key],
out_dir=out_dir,
name=key,
**extra_kw
)
)
except Exception as e:
logger.warning('unable to construct %s product: %s from this: %s ', key, e, output[key])

is some adjustments to the class needed?

EDIT: to mention, if I remove the label extra annotation, the exception does not appear

@dsavchenko
Copy link
Member

I didn't manage to reproduce it locally

@burnout87
Copy link
Contributor Author

which notebook are you running?

@dsavchenko
Copy link
Member

NB2WProduct class needs to be adapted to accept extra_ttl.
To think of taking oda:label into account. The simplest way is to set the product name to the label content. But it may affect usability of result in oda_api (having long names for properties)

@dsavchenko dsavchenko linked a pull request Oct 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants