upgrade Python version at least > 3.9, hopefully 3.12

[volodymyrss]

following oda-hub/oda_api#279 (review)

[volodymyrss]

I propose that @burnout87 does it to better keep track of the code dependencies.

[burnout87]

I guess you mean restrict to use python versions to only 3.10 and 3.11...?

[volodymyrss]

It's fixed container environment and it has a single version, currently 3.8.

Since we are dropping support of 3.8, we should increase the version in the container to the largest version we can support. If 3.12 works it's even better. Probably 3.12.

Doing this might lead to dependency issues which need to be reconciled.

[volodymyrss]

But this means rebuilding osa+heasoft with new python which might not work easily.

We only need them for xspec functionality I guess.

Would you try building new OSA+Heasoft by upgrading https://github.com/ISDC-integral/osa-python-docker/? It's useful anyway.

If it does not work so easily, we can replace or drop the xspec functionality.

[burnout87]

Would you try building new OSA+Heasoft by upgrading https://github.com/ISDC-integral/osa-python-docker/? It's useful anyway.

I need permission on that repo to make a PR

[volodymyrss]

Would you try building new OSA+Heasoft by upgrading https://github.com/ISDC-integral/osa-python-docker/? It's useful anyway.

I need permission on that repo to make a PR

Did you make a fork?

[burnout87]

Would you try building new OSA+Heasoft by upgrading https://github.com/ISDC-integral/osa-python-docker/? It's useful anyway.

I need permission on that repo to make a PR

Did you make a fork?

no I just cloned it, I'll make a fork...

[volodymyrss]

Would you try building new OSA+Heasoft by upgrading https://github.com/ISDC-integral/osa-python-docker/? It's useful anyway.

I need permission on that repo to make a PR

Did you make a fork?

no I just cloned it, I'll make a fork...

Ok! Actually looks like the latest version is built by Carlo and it's with 3.10. We should check it.

[burnout87]

it fails for xspec

https://github.com/oda-hub/dispatcher-container/actions/runs/10521973707/job/29153665851?pr=16

[volodymyrss]

it fails for xspec

https://github.com/oda-hub/dispatcher-container/actions/runs/10521973707/job/29153665851?pr=16

I think the container should support xspec. If not, please make an issue on osa-python-docker and assign to @ferrigno .

[burnout87]

and it builds without xpec

[volodymyrss]

and it builds without xpec

What do you mean?

[burnout87]

By commenting the lines:

dispatcher-container/Dockerfile

Lines 13 to 14 in c0953ee

	RUN source /init.sh && \
	python -c 'import xspec; print(xspec)'

it was successfully building

[burnout87]

To be more precise:

With the following version of the container: integralsw/osa-python:11.2-2-g667521a3-20220403-190332-refcat-43.0-heasoft-6.33-python-3.10.11

It does not build

With this one: integralsw/osa-python:11.2-2-g667521a3-20220403-190332-refcat-43.0-heasoft-6.32.1-python-3.10.11

it does build

It looks like the difference between is the heasoft version, is there something else?

[ferrigno]

It should not be anything different but heasoft. I might have corrected issues with the latter version Il Ven 23 Ago 2024, 10:43 Gabriele Barni ***@***.***> ha scritto:

…

To be more precise: With the following version of the container: FROM integralsw/osa-python:11.2-2-g667521a3-20220403-190332-refcat-43.0-heasoft-6.33-python-3.10.11 It does not build With this one: FROM integralsw/osa-python:11.2-2-g667521a3-20220403-190332-refcat-43.0-heasoft-6.32.1-python-3.10.11 it does build It looks like the difference between is the heasoft version, is there something else? — Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATI74256VWBZYY3R4NNRALZS3Y2XAVCNFSM6AAAAABM37AAGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGYYDENBSHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[volodymyrss]

We don't really care about the effect of the heasoft version increase here. Better to keep the old one, if anything.
So if it builds one, let's keep it!

[burnout87]

I think the container should support xspec. If not, please make an issue on osa-python-docker and assign to @ferrigno .

ISDC-integral/osa-python-docker#4 (comment)