Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renku publish not working, message not too helpful #659

Open
volodymyrss opened this issue Feb 14, 2024 · 26 comments
Open

renku publish not working, message not too helpful #659

volodymyrss opened this issue Feb 14, 2024 · 26 comments
Assignees

Comments

@volodymyrss
Copy link
Member

At the moment I get this:

image

It is not helpful since I do not know what to do about it.
There could be two possibilities:

  1. this account has no permission to publish to renku. in this case, we want to write it in the message
  2. something is broken internally. if so, we should get sentry alert.

Could you please help, @burnout87 ?

@burnout87
Copy link
Collaborator

trying from my local instance of the frontend and sending the request to the staging instance I get the following error:

image

and this is the sentry

https://cdci.sentry.io/issues/4976758863/?project=1467382&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=30d&stream_index=0

@volodymyrss
Copy link
Member Author

Ok so what happens in production instance. Where does this error I see comes from?

@burnout87
Copy link
Collaborator

if it's this one:

https://cdci.sentry.io/issues/4893374449/?project=1467382&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=30d&stream_index=2

then it's of the same type: FileNotFoundError: [Errno 2] No such file or directory: 'scratch_sid_50BTX84NHLULEU5A_jid_5ae54239b14c7cb2/query_output.json'

@burnout87
Copy link
Collaborator

In both cases the error is the same, just that the issue posted at the beginning happens on the production, which doesn't runs the latest version of the frontend which, instead, adds displays a more informative hints for the user.

https://github.com/oda-hub/mmoda-frontend-module/blob/27e262f08589b9cd8bd33a84f334f46100fbbd30/js/mmoda.instrument.js#L880-L894

I will add another sentry, more comprehensive, to be sent from the dispatcher

@volodymyrss
Copy link
Member Author

But the root problem is in dispatcher, right?

@burnout87
Copy link
Collaborator

burnout87 commented Feb 14, 2024

But the root problem is in dispatcher, right?

I doubt it, but I am trying to investigate it using my local instance

@volodymyrss
Copy link
Member Author

But the root problem is in dispatcher, right?

I doubt it, but I am trying to investigate it using my local instance

It misses: scratch_sid_50BTX84NHLULEU5A_jid_5ae54239b14c7cb2/query_output.json

This file is created by dispatcher and should be read by it.
Do you propose that the problem elsewhere?

@burnout87
Copy link
Collaborator

It misses: scratch_sid_50BTX84NHLULEU5A_jid_5ae54239b14c7cb2/query_output.json

This file is created by dispatcher and should be read by it. Do you propose that the problem elsewhere?

I am wondering why that file is not there.

@burnout87
Copy link
Collaborator

burnout87 commented Feb 14, 2024

now I see this:

something happened while pushing the api_code: cloning repository
Cmd('git') failed due to: exit code(128)
  cmdline: git clone -v --branch=master --progress -- [email protected]:astronomy/mmoda/mmoda-request.git /tmp/mmoda-request1dojhcsv

https://cdci.sentry.io/issues/4962054192/?project=1467382&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=30d&stream_index=1

@burnout87
Copy link
Collaborator

Could it be related to the ssh key no longer being valid? I had the same issue with my test branch locally

@ferrigno
Copy link
Contributor

ferrigno commented Mar 4, 2024

I think that a feature not working in production should have a high priority. If solution requires time, one should remove the button temporarily. It is annoying for a user to have something never working and it is bad for our web platform. After three weeks from the issue being open, it is time either to solve it or remove the button.

@volodymyrss
Copy link
Member Author

@ferrigno, this feature is open only to selected few users, to whom we explain the situation personally. These few users should hopefully show some understanding.

If you do not want to be among those select users, I can remove you right now?

@burnout87
Copy link
Collaborator

burnout87 commented Mar 4, 2024

This is the issue that happens in production. It has already been fixed and pushed in the staging, so soon it'll be available in production

https://cdci.sentry.io/issues/5035433154/?project=1467382&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=30d&stream_index=0

@burnout87
Copy link
Collaborator

burnout87 commented Mar 4, 2024

To be kept in mind that the project we use for pushing on renku needs to be updated to the latest version of Renku (2.9.1), along with the update of the renkulab project template.

This will also, amongst the other things, adapt the environemnt.yml file according to https://renku.discourse.group/t/addressing-issues-with-renku-image-builders/892

The update will, obviously, push some changes on the master branch

@ferrigno
Copy link
Contributor

ferrigno commented Mar 4, 2024

I updated it.

@ferrigno
Copy link
Contributor

ferrigno commented Mar 4, 2024

Please update the production instance, it is really annoying to have a non-working button

@volodymyrss
Copy link
Member Author

Please update the production instance, it is really annoying to have a non-working button

@ferrigno , to make sure you have a helpful message, I removed the renku developer role from your account, does it look ok now?

image

The update will be deployed with the next devops upgrade.

@ferrigno
Copy link
Contributor

ferrigno commented Mar 5, 2024

@volodymyrss it was not clear to me that this feature of 'view on renku' is visible only for people with a certain role (and your first reply reached me after my second comment, which was clearly useless at that point).

@burnout87
Copy link
Collaborator

Tried just now after there was a new release on the production, and I see the following error. I encountered the same error testing with my local repo, and I resolved it by updating my ssh key.

https://cdci.sentry.io/issues/5041641945/?project=1467382&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=30d&stream_index=0

@volodymyrss
Copy link
Member Author

Did it change since yesterday release though? Could you please refer to the commit responsible for the renku update here?

@volodymyrss
Copy link
Member Author

By the way, the issue should be visible from the sentry, it looks like not the key but the URL, isn't it?

@volodymyrss
Copy link
Member Author

Does the git URL look correct for you though?

@burnout87
Copy link
Collaborator

Does the git URL look correct for you though?

It does to me, I also tried locally and I could clone

@burnout87
Copy link
Collaborator

Could you please refer to the commit responsible for the renku update here?

The error message changed since the release of the dispatcher in production, since the way the information to be pushed in the renkulab branch has cheanged. But the current error is more related to the configuration on their side, which requires an update as well on our.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants