New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove broken cmake code for e2k. #10575
Comments
Support was added by a contributor 4 years ago: #3288 Probably worth just dropping support at this point, but unlikely to be something we fix ourselves as we don't have access to any e2k machines. Feel free to open a PR to remove the problematic code. |
@makise-homura Not sure if you're still participating on github all that much, but if you're around it seems that e2k isn't currently compiling. @ilyakurdyukov It's one thing to say "There's a bug in this code" or "this code is incorrect", and maybe I would have even been fine with "buggy code", but saying "poorly written" is unnecessary wording that goes beyond that, don't you think? It was kind enough that a contributor came around to advocate for and add support for e2k, so I don't see the point of adding unnecessary wording such as "poorly written" other than to be abrasive. Please kindly keep such abrasive and unnecessary wording out of our repository, and keep things constructive as per our conduct guidelines. We try to work together, not against one another. Anyway, you're saying to remove it, but whether we remove it or not, it's not like anything will change for people who use e2k anyway if it were removed. If it's not currently compiling then it still won't compile anyway. So I'm not sure why you even made this issue report. Probably would have been better to just to ignore it at that point and move on from. |
@makise-homura, please fix this. This breaks I successfully built the
The only spam warning in the log:
This warning appeared 3419 times during the build. |
Operating System Info
Other
Other OS
AltLinux
OBS Studio Version
30.1.2
OBS Studio Version (Other)
No response
OBS Studio Log URL
none
OBS Studio Crash Log URL
No response
Expected Behavior
cmake should succeed
Current Behavior
obs-studio/cmake/Modules/CompilerConfig.cmake
Line 171 in 10bfa99
This code uses a minus sign from the warning option in the variable name, which breaks cmake.
And then cmake fail on any compile tests, like this:
I didn’t find in the history who added this code for e2k. It's better to delete this code, you won't be able to maintain it. And those distributions that work with this architecture will patch it themselves.
Steps to Reproduce
try to build on e2k machine
Anything else we should know?
Where's the build issues template, did you expect this to never happen?
The text was updated successfully, but these errors were encountered: