-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: Tengwar #4954
base: master
Are you sure you want to change the base?
Add plugin: Tengwar #4954
Conversation
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1]:Please remove the [1][2]:Using [1]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. Do NOT open a new PR for re-validation. |
/skip
In the place where I assign the style directly, I set the value from the settings. This is necessary for flexible color adjustment by a user. |
I made the others changes and pushed them. |
Changes requested by bot have been made, ready for additional review by human. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. Do NOT open a new PR for re-validation. |
/skip
In the place where I assign the style directly, I set the value from the settings. This is necessary for flexible color adjustment by a user. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/mikevetkin/obsidian-tengwar
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.