Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify schema module further. #712

Open
obmarg opened this issue Jun 11, 2023 · 0 comments · May be fixed by #798
Open

Simplify schema module further. #712

obmarg opened this issue Jun 11, 2023 · 0 comments · May be fixed by #798
Labels
breaking A breaking change ✨ enhancement New feature or request
Milestone

Comments

@obmarg
Copy link
Owner

obmarg commented Jun 11, 2023

Even with pre-registration, generating and compiling large schemas isn't as fast as it could be. Some of that slow down is generating & subsequently compiling the use_schema output.

Looking at the shape of the output I think there might be room to simplify it:

  • The Field trait could probably be dropped in favour of HasField & HasInputField
  • HasInputField might not need its second generic parameter.

These changes would probably reduce the output size quite significantly which would provide a fair bit of speed up. Likely a breaking change, but not one that would affect most users.

@obmarg obmarg added the ✨ enhancement New feature or request label Jun 11, 2023
@obmarg obmarg added this to the 4.0.0 milestone Jun 11, 2023
@obmarg obmarg linked a pull request Dec 30, 2023 that will close this issue
@obmarg obmarg added the breaking A breaking change label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change ✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant