Simplify the schema module #798
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cynic-querygen-web canceled.
|
obmarg
force-pushed
the
obmarg/push-nnuummwqwyov
branch
from
6953023
to
f17bc77
Compare
obmarg
force-pushed
the
obmarg/push-nnuummwqwyov
branch
from
f17bc77
to
63e6194
Compare
|
A further optimisation that could maybe be made to this: deduplicating fields. At the moment there's a separate field struct created for each object<>field pair, with (iirc) the string literal living on the HasField impl. I could try to have a single field struct for each field name that's present in the schema, with only seperate HasField impls for each object<>field pair. I think this would be particularly effective if I find somewhere else to store the field name literals... Worth looking into making the same optimisation with arguments... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we making this change?
The cynic schema module is overly verbose - the same data could be expressed with less code.
What effects does this change have?
Fieldtrait, moving its data into theHasField&HasInputFieldtraits.HasInputFieldto an associated type.This reduces the size of the schema module quite considerably, which should have a reasonable impact on compile times (~a 10% reduction in compile times of my test crate that uses the GitHub schema). It also has the bonus impact of simplifying some of the query building where clauses.
This is probably a breaking change though so should maybe be a major release.
Fixes #712