Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

docs: Component Schematic concepts article misleading table #406

Closed
macolso opened this issue Oct 29, 2019 · 4 comments · Fixed by #435
Closed

docs: Component Schematic concepts article misleading table #406

macolso opened this issue Oct 29, 2019 · 4 comments · Fixed by #435
Labels
Status: Completed Issue or PR is complete and has been merged into latest release candidate Status: Good-First-Issue Good for newcomers Type: Docs Documentation
Milestone
1.0.0-alpha.2

Comments

@macolso
Copy link
Contributor

macolso commented Oct 29, 2019 •
edited by suhuruli
Loading

Under the Container section of the https://github.com/oam-dev/rudr/blob/master/docs/concepts/component-schematic.md#containers concept article, the resources row is not ticked as "required". This is partially misleading since some of the resources are required but not all (see here). I think the resources row should be marked as required on the Container section
@macolso
Copy link
Contributor Author

macolso commented Oct 29, 2019

also - are parameter overrides supported in Rudr?

@suhuruli
Copy link
Contributor

also - are parameter overrides supported in Rudr?

Yes

@suhuruli suhuruli added Status: Available This is available to be picked up by someone Status: Good-First-Issue Good for newcomers Type: Docs Documentation labels Oct 29, 2019
@wonderflow
Copy link
Member

wonderflow commented Oct 30, 2019 •
edited
Loading

Yeah, I think resources should be ticked as "required" now.

Some more discussion: oam-dev/spec#218

@wonderflow
Copy link
Member

wonderflow commented Oct 30, 2019 •
edited
Loading

also this is not implemented in rudr #277 #364

@wonderflow wonderflow mentioned this issue Oct 30, 2019
Merged
@suhuruli suhuruli added this to the 1.0.0-alpha.2 milestone Nov 25, 2019
@suhuruli suhuruli added Status: Completed Issue or PR is complete and has been merged into latest release candidate and removed Status: Available This is available to be picked up by someone labels Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Completed Issue or PR is complete and has been merged into latest release candidate Status: Good-First-Issue Good for newcomers Type: Docs Documentation
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

make resource required and also fix examples to be consistent with spec wonderflow/rudr
3 participants
@wonderflow @suhuruli @macolso