-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @types/react-tracking #172
Comments
Yes, that'd be great. TypeScript types via DefinitelyTyped, @types/react-tracking, are a community-driven effort currently. Although we do have plans to rewrite the internals to TypeScript and thus export type definitions directly (see #152 for WIP or if you'd like to contribute) Also as noted in #173 by @mattes3:
|
Hi all. I ran into an issue where, in TS, I couldn't pass a function as the first argument to Thank you! Love the library. |
Just wanted to bump this. I've gotten approval from the definitivelytyped maintainers but will wait till the evening of 5/3, or someone here says otherwise, to merge it in case anyone from this repo has opinions on the change. I've got the changes locally running on a production site so I'm pretty certain it's safe, just want to make sure the owners of this repo don't have any issues with it. |
Those updates look good @trescenzi -- thanks so much for contributing. It's greatly apprecaited! |
Is it possible to update the types for the
useTracking
hook to allow for passing in an object.The text was updated successfully, but these errors were encountered: