-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: Switch all exec calls to proc_open #25
Labels
Comments
@rungta I think really what should happen is they should all be switched over to use the protected function executeShellCommand(string $command): string
{
// Create the shell command
$shellCommand = new ShellCommand();
$shellCommand->setCommand($command);
// If we don't have proc_open, maybe we've got exec
if (!\function_exists('proc_open') && \function_exists('exec')) {
$shellCommand->useExec = true;
} The good news is that there are only 3 places where |
khalwat
changed the title
Refactor request: Switch all exec calls to proc_open
[FR]: Switch all exec calls to proc_open
Nov 8, 2019
I take it back, it's not a simple swap-out because |
Yeah, I assumed there must’ve been a good reason why it wasn’t already making use of `executeShellCommand`. My experience with both these functions is fairly limited though, so not sure of the intricacies.
… On 09-Nov-2019, at 19:57, Andrew Welch ***@***.***> wrote:
I take it back, it's not a simple swap-out because exec() returns an array, and the shellCommand returns a string.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Could the
exec
calls in the code base be switched toproc_open
for wider compatibility with systems whereexec
is disabled (and better security?)?The text was updated successfully, but these errors were encountered: