Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nxpm/stack:init should have to option to use a default branch different than main #69

Open
ruslanguns opened this issue Jan 19, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ruslanguns
Copy link
Contributor

Expected Behavior

If you generate a new project and your global default branch is different than main , scripts like affected and format will throw errors.

Current Behavior

Possible Solution

Solution has been commented in the PR #68 -> #68 (comment)

Steps to Reproduce (for bugs)

  1. Having a different default branch name than main globally
  2. generate new project
  3. by running affected or format will throw error
  4. husky will also throw error on new commits

Context

Your Environment

  • Version used: 4.4.6
  • Browser Name and version: n/a
  • Operating System and version (desktop or mobile): Tested on Windows and Linux
  • Link to your project: n/a
@beeman beeman added the enhancement New feature or request label Jan 19, 2021
@beeman beeman changed the title Error with affected and format scripts if default branch are different than main @nxpm/stack:init should have to option to use a default branch different than main Jan 19, 2021
@beeman
Copy link
Member

beeman commented Jan 19, 2021

Updated the description as #68 will now force the initial branch to be main.

Things to do in this change:

  • @nxpm/stack:init accepts property --defaultBase
  • nxpm-stack init command from @nxpm/cli accepts property --defaultBase
  • the --defaultBase option will be passed to yarn create nx-workspace

@beeman beeman added the help wanted Extra attention is needed label Jan 23, 2021
@beeman beeman added this to the After Nx 11 upgrade milestone Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants