Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon as app icon regression #8165

Open
TheJaredWilcurt opened this issue Feb 13, 2024 · 0 comments
Open

Favicon as app icon regression #8165

TheJaredWilcurt opened this issue Feb 13, 2024 · 0 comments
Labels
bug has-min-repro Has a minimum reproduction regression

Comments

@TheJaredWilcurt
Copy link
Member

TheJaredWilcurt commented Feb 13, 2024 •
edited

In some older versions I can load up this app:

{
  "name": "test",
  "main": "index.html"
}
<!DOCTYPE html>
<html>
  <head>
    <link rel="icon" href="black.ico" >
  </head>
  <body>
  </body>
</html>

Then the start bar will show the correct icon and the window title bar will have the correct icon. I can then change the href to white.ico and both visible icons update automatically.

Favicon bug report screenshot

NW.js title bar taskbar Can update visible icon
0.14.7 ✔️ ✔️ ✔️
0.23.3 ✔️ ✔️ ✔️
0.24.4 ✔️ ✔️ ✔️
0.25.0-beta1 ✔️ ❌ ✔️
0.25.2 ✔️ ❌ ✔️
0.26.0 ✔️ ❌ ✔️
0.28.1 ✔️ ❌ ✔️
0.33.4 ✔️ ❌ ✔️
0.40.0-beta1 ✔️ ❌ ✔️
0.43.0-beta1 ✔️ ❌ ✔️
0.43.0 ✔️ ✔️ ✔️
0.43.1 ✔️ ✔️ ✔️
0.43.2 ✔️ ✔️ ✔️
0.43.3 ✔️ ✔️ ✔️
0.43.4 ✔️ ✔️ ✔️
0.43.5 ❌ ❌ ❌
0.43.6 ❌ ❌ ❌
0.44.0-beta1 ✔️ ✔️ ✔️
0.44.0 ❌ ❌ ❌
0.44.6 ❌ ❌ ❌
0.45.0-beta1 ❌ ❌ ❌
0.45.5 ❌ ❌ ❌
0.79.0 ❌ ❌ ❌
0.84.0 ❌ ❌ ❌

All tested on Windows 10 with 64-bit SDK versions.

And yes you are reading that right. The bug comes and goes at a few different previous versions. Very weird.

Min Repro:
@TheJaredWilcurt TheJaredWilcurt added bug regression has-min-repro Has a minimum reproduction labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has-min-repro Has a minimum reproduction regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheJaredWilcurt