Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Material Symbols #127

Open
AndersCV opened this issue Apr 19, 2024 · 2 comments · May be fixed by #133
Open

Add support for Google Material Symbols #127

AndersCV opened this issue Apr 19, 2024 · 2 comments · May be fixed by #133
Labels

Comments

@AndersCV
Copy link

AndersCV commented Apr 19, 2024

Currently it is not possible to use google as a provider for Material Symbols.

Looking at the current implementation of the google provider it seems it's only looking at the meta data for fonts found at: https://fonts.google.com/metadata/fonts

Uploading image.png…

Metadata for googles Material Symbols can be found at https://fonts.google.com/metadata/icons

@qwerzl
Copy link
Collaborator

qwerzl commented Apr 19, 2024

Icon's metadata is in a completely different format than Fonts, so we might need to create a new provider for that. @danielroe What do you think?

Meanwhile, you could always use the material symbols provided by the fontsource provider.

@AndersCV
Copy link
Author

@qwerzl Thanks for the response and suggetions. I thought the same but unfortunately Material Symbols provided by google is not totally identical to that of fontsource which is blocking us from changing.

As a workaround I'll try and create my own custom provider for Google Material Symbols, however I do think this module should support it out of the box.

@qwerzl qwerzl linked a pull request Apr 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants