Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useIonRouter() is missing isReady() from vue-router? #465

Closed
chrisspiegl opened this issue Sep 25, 2023 · 2 comments
Closed

feat: useIonRouter() is missing isReady() from vue-router? #465

chrisspiegl opened this issue Sep 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@chrisspiegl
Copy link

chrisspiegl commented Sep 25, 2023

馃啋 Your use case

Waiting for the page / router to be ready when loading a page.

馃啎 The solution you'd like

vue-router via useRouter() in Nuxt supports await useRouter().isReady() which is super useful to wait for a page to finish loading.

I expected useIonRouter() to also have this but appears it does not.

Maybe this can be implemented, or is there an alternative I should use?

Thank you 馃尭,
Chris

馃攳 Alternatives you've considered

Using useRouter().isReady() inside my Nuxt/Ionic app appears to be working as expected. But I thought it would be cleaner to have only useIonRouter in the project instead of mixing it.

@chrisspiegl chrisspiegl added the enhancement New feature or request label Sep 25, 2023
@danielroe danielroe removed their assignment Jan 9, 2024
@CHIBX
Copy link
Contributor

CHIBX commented May 22, 2024

@chrisspiegl The Ionic team mentioned the use of vue-router's useRouter() working well.
That has the method you are looking for

@danielroe
Copy link
Collaborator

I think you should use both composables - when required.

@danielroe danielroe closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants