Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: Before mount, await useFetch #741

Open
arkhamvm opened this issue Feb 8, 2023 · 13 comments
Open

help: Before mount, await useFetch #741

arkhamvm opened this issue Feb 8, 2023 · 13 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@arkhamvm
Copy link

arkhamvm commented Feb 8, 2023

馃摎 What are you trying to do? Please describe.
On the client, before component will be mounted, I want to completely load data.

馃攳 What have you tried?

	setup() {
		const pageData = ref<PageData | null>(null);

		const {params, error} = useContext();
		useFetch(async () => {
			const pageDataStore = usePageDataStore();

			await pageDataStore.fetchDataById(params.value.id);

			pageData.value = pageDataStore.currentData;
			if (null === pageData.value) {
				return error({statusCode: 404, message: 'Not Found'});
			}
		});

		return {
			pageData,
		};
	},

鈩癸笍 Additional context
According to Nuxt lifecycle, I expect that useFetch will be completely done, like fetch does.
This is especially distressing in pageComponents - page transition is complete, but page is empty and waiting for data.

https://nuxtjs.org/_nuxt/image/de48ca.svg

@rchl
Copy link
Member

rchl commented Mar 30, 2023

Do you have a simple example that you could share that doesn't use custom functions like usePageDataStore that we don't have access to?

@rchl rchl added the needs-repro Waiting for code that can reproduce the issue label Mar 30, 2023
@arkhamvm
Copy link
Author

It can be anything, just await sleep 5 seconds

@rchl
Copy link
Member

rchl commented Mar 31, 2023

What is your issue in the first place? Can you provide a reproduction and specify the steps to reproduce and expected behavior?

Also are you doing SPA navigation? There is a lot of stuff to guess here and if you don't help us with all the needed information then we can't help you. Please do your share of the work if you expect help.

@arkhamvm
Copy link
Author

arkhamvm commented Mar 31, 2023

Sorry, just finished with repro repo:
https://codesandbox.io/s/determined-wood-ludn1b?file=/pages/posts/index.vue

Click on "Post" link. Page will show "LOADING" for 3 seconds after navigation.
I need to do navigation after fetch is completed.

are you doing SPA navigation?

Yes, I writed it before:

page transition is complete, but page is empty and waiting for data

@rchl
Copy link
Member

rchl commented Mar 31, 2023

That's how fetch (useFetch) is supposed to work AFAIK. On SPA navigation it doesn't block page loading and it exposes $fetchState so that you handle loading state in the page itself.

If you expect the behavior where the page loading is blocked until full load then you should use asyncData (useAsync). But to be fair I've tried that now and that one also doesn't block page loading on SPA navigation... So maybe that's buggy? Not sure, I haven't started using this module properly yet.

See my CS that uses useAsync: https://codesandbox.io/s/runtime-wind-svbdd3?file=/pages/posts/index.vue.

@rchl
Copy link
Member

rchl commented Mar 31, 2023

(BTW. If my codesandbox doesn't work the it's probably codesandboxes fault. Maybe download it and try locally)

@danielroe
Copy link
Member

Here's a stackblitz we can use: https://stackblitz.com/edit/github-jc3ome.

@rchl
Copy link
Member

rchl commented Mar 31, 2023

So useAsync also doesn't really promise that it will block page navigation. This is an excerpt from the documentation:

However, if the call hasn't been carried out on SSR (such as if you have navigated to the page after initial load), it returns a null ref that is filled with the result of the async call when it resolves.

It's quite confusing given that it's called very similar to useAsyncData which does block navigation in Nuxt 3.

Here is a Nuxt 3 example that DOES block navigation: https://stackblitz.com/edit/github-jmkwfk?file=pages%2Findex.vue,package.json,pages%2Fposts%2Findex.vue

And here is Nuxt 2 which doesn't: https://stackblitz.com/edit/github-jc3ome-osg6rc?file=pages%2Fposts%2Findex.vue

I'm not sure if the intention is that the Options API is used when requiring asyncData behavior? Do you know @danielroe?

@rchl rchl added documentation Improvements or additions to documentation needs-repro Waiting for code that can reproduce the issue and removed needs-repro Waiting for code that can reproduce the issue labels Mar 31, 2023
@rchl
Copy link
Member

rchl commented Mar 31, 2023

Seems like this is not intended to work like asyncData. Daniel made it clear in #623.

Thus I would just use this issue for clarifying this in the documentation.

@arkhamvm
Copy link
Author

arkhamvm commented Apr 1, 2023

So, what I should to do?
Just not use composition-api with Nuxt2?

@danielroe
Copy link
Member

Blocking route change with a composable is not supported by the Vue 2 composition API. This is why, when we rewrote Nuxt composables in Nuxt Bridge, we chose to use useLazyAsyncData - to avoid potential confusion.

@arkhamvm
Copy link
Author

arkhamvm commented Apr 1, 2023

@danielroe Bridge still marked as not ready for production and have dependency issues in my project.
Maybe it can be done with router middleware? Check fetchState for example?

@rchl
Copy link
Member

rchl commented Apr 1, 2023

Bridge still marked as not ready for production and have dependency issues in my project.

I think you misunderstood. Bridge also doesn't support it. The useLazyAsyncData name was used to signify that it doesn't block navigation.

@rchl rchl removed the needs-repro Waiting for code that can reproduce the issue label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants