-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth2 URL may already contain query parameters #1831
Labels
Comments
I'm also facing this issue - did you find a workaround? |
I submitted Pull Request about this issue before. This PR is not merged yet, but I apply this change to my app by using patch-package (https://www.npmjs.com/package/patch-package) I hope this will help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
module: 5.0.0-1667386184.dfbbb54
nuxt: 2.15.8
Nuxt configuration
mode:
Nuxt configuration
Reproduction
What is expected?
In some cases, authorization endpoint URL already contains query parameters. (e.g Azure AD B2C specifies "user flow name" by using query parameters)
If OAuth2 authorization endpoint URL contains '?' (=already has query params), this module should join options generated by this module to given URL with '&' ,not '?'.
auth-module/src/schemes/oauth2.ts
Line 306 in dfbbb54
What is actually happening?
Redirect to authorization endpoint fails because authorization URL is like this↓
https://example.com/oauth2/authorize ? given_param=something ? param_generated_by_this_module=something&other_param=...
"?" appears twice
Steps to reproduce
Set up Azure AD B2C and write configuration above
,or just specify authorization endpoint with some query parameters
Additional information
Checklist
The text was updated successfully, but these errors were encountered: