Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve is_connected error handling #9

Open
patrickfuller opened this issue Aug 2, 2018 · 0 comments
Open

Improve is_connected error handling #9

patrickfuller opened this issue Aug 2, 2018 · 0 comments
Labels
enhancement

Comments

@patrickfuller
Copy link
Member

Related to #7.

Right now, a flow controller will return False if initialized as a FlowMeter. We should consider a more verbose approach to is_connected covering the following scenarios:

  • Nothing's connected
  • Nothing's communicating
  • Something's communicating, but it's not an Alicat
  • An Alicat is communicating, but it's not a FlowMeter / FlowController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patrickfuller