Reactive issue

[caesar1shi]

Is it necessary to set self.update() in the set function of ctx? Otherwise, we cannot get a response in the DOM when setting properties.

https://github.com/nuejs/nue/blob/master/packages/nuejs/src/browser/nue.js

[tipiirai]

The self.update() updates the dom to reflect the properties on the component instance.

cannot get a response in the DOM when setting properties.

What exactly you mean by this?

Thanks!

[caesar1shi]

<div class="sidebar { isCollapsed ? 'collapsed' : '' }">
  <script>
    onSidebarCollapse() {
      this.isCollapsed = true
    }

    onSidebarExpand() {
      this.isCollapsed = false
    }
  </script>
</div>

For example, after calling onSidebarExpand to assign a value to isCollapsed, it cannot change the value of the class. Because the call to self.update is currently missing.

[caesar1shi]

We need to call self.update to update the component after setting properties, or we can just update the component content related to the property. As follows:

  function updateProperty(key) {
    expr.forEach((el) => {
      if (el.toString().includes(key))
        el();
    });
  }

  set(__, key, val) {
    if ($parent && $parent[key] !== void 0) {
      $parent[key] = val;
      $parent.update();
    } else {
      self[key] = val;
      self.updateProperty(key);
    }
    return true;
  }

[caesar1shi]

The call to self.update is currently missing.

[tipiirai]

Nicely spotted!

Note that the client-side Nue JS is not currently under heavy development because there are some major pieces in the product development roadmap before the SPA stuff. There are quite many issues on the reactive lib, but they're addressed later. I should add a note to the README file about this.

Also — to add self.update() to that spot might cause unwanted side-effects. I think we need a proper client-side test suite for the reactive pieces before adding that change.

[caesar1shi]

Got it

[tipiirai]

Thanks. I created a pinned issue for this.