Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fit params for LightGBM #117

Open
ValeriaGomes opened this issue Jan 13, 2020 · 5 comments
Open

Allow fit params for LightGBM #117

ValeriaGomes opened this issue Jan 13, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@ValeriaGomes
Copy link
Contributor

ValeriaGomes commented Jan 13, 2020

Describe the feature and the current state.

  • LightGBM has several parameters inside the fit method. One possible solution is to add a fit_params into the LightGBM function in FkLearn for increased flexibility.
  • This improvement would have to be done for both classification and regression.

Will this change a current behavior? How?

We would be able to configure the fit function using FkLearn.

Additional Information

https://lightgbm.readthedocs.io/en/latest/pythonapi/lightgbm.LGBMClassifier.html#lightgbm.LGBMClassifier.fit

@ValeriaGomes ValeriaGomes added the enhancement New feature or request label Jan 13, 2020
@sadikneipp
Copy link
Contributor

sadikneipp commented Jan 13, 2020

@sadikneipp
Copy link
Contributor

Hmm I'm wrong, this argument only covers the hyperparameter section here https://lightgbm.readthedocs.io/en/latest/Parameters.html

@sadikneipp
Copy link
Contributor

Any specific behaviour you feel we are missing @ValeriaGomes? I see there's some overlap between what extra_params cover and the params in the link you sent

@ValeriaGomes
Copy link
Contributor Author

ValeriaGomes commented Jan 13, 2020

@sadikneipp : Good point! I hadn't seen the extra_params. I'll check if there're parameters missing and if it's not the case, I'll close the issue.

@robotenique
Copy link
Contributor

🆙 on this, I think with the current learners we cannot pass a validation set to work with early stopping in LightGBM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants