Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint rules not applied after migrating to flat config #23077

Closed
1 of 4 tasks
philipjfulcher opened this issue Apr 29, 2024 · 0 comments · Fixed by #23263
Closed
1 of 4 tasks

eslint rules not applied after migrating to flat config #23077

philipjfulcher opened this issue Apr 29, 2024 · 0 comments · Fixed by #23263
Assignees
Labels
scope: linter Issues related to Eslint support in Nx type: bug

Comments

@philipjfulcher
Copy link
Collaborator

Current Behavior

After migrating to eslint flat config, eslint rules are not applied.

Expected Behavior

After migrating to flat config, eslint rules are applied as before.

GitHub Repo

https://github.com/philipjfulcher/eslint-flat-config-repro

Steps to Reproduce

  1. Clone https://github.com/philipjfulcher/eslint-flat-config-repro and install packages
  2. Run npx nx lint eslint-repro and note that there is an error and warning in apps/eslint-repro/src/app/app.component.ts
  3. Checkout branch flat-config where flat config migration generator has been run
  4. Run npx nx lint eslint-repro and note that it passes with no errors or warnings.
  5. Checkout branch flat-config-working where empty rulesets have been removed from eslint.config.js
  6. Run npx nx lint eslint-repro and note that there is an error and warning in apps/eslint-repro/src/app/app.component.ts

Nx Report

NX   Report complete - copy this into the issue template

Node   : 20.11.1
OS     : darwin-arm64
npm    : 10.2.4

nx                 : 18.2.4
@nx/js             : 18.2.4
@nx/jest           : 18.2.4
@nx/linter         : 18.2.4
@nx/eslint         : 18.2.4
@nx/workspace      : 18.2.4
@nx/angular        : 18.2.4
@nx/devkit         : 18.2.4
@nx/eslint-plugin  : 18.2.4
@nx/plugin         : 18.2.4
@nrwl/tao          : 18.2.4
@nx/web            : 18.2.4
@nx/webpack        : 18.2.4
typescript         : 5.4.5

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

Using rules: {} seems to remove all of the rules from the extended config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: linter Issues related to Eslint support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants