New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NX Daemon Server crashing when running pnpm install
#23031
Comments
Downgrade pnpm to v8, it will solve the issue
|
This isn't a proper solution - pnpm 9 may be needed for certain projects (also, regressions shouldn't be solved by "just downgrade" - unless the maintainers of the affected software indicate that's the intended solution). A possible solution would be to, wherever the relevant source code is (im just patching the output to get my setup working temporarily as a workaround whilst testing) use something like Interestingly, in my short testing, replacing it with anything to get the value of |
Update: found the root cause after a bit more messing around trying to get
|
Still see this on 19.0.3
|
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> When there are watch event changes, and we filter them all out, we get an empty `changedEvents` array. There were previous checks that had a `!changedEvents.length` condition that resolved to true when the length was 0. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> We now check to see if `err` is set before triggering the error branch ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23031
Current Behavior
Subsequent to #21492, we upgraded to 18.3.4 which contains the fix, and removed our hacky workaround where we call
nx reset
after runningpnpm install
due to the daemon serverpanic
ing in the Rust code.We now see a different error:
Expected Behavior
We would expect the daemon not to crash when running
pnpm install
GitHub Repo
No response
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
pnpm 9.0.2
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: