Bluetooth: Advertising resume functionality is broken #72567

jori-nordic · 2024-05-10T11:37:09Z

Describe the bug

This feature only works when using legacy advertising
This feature will attempt to change the random address while a scanner/initiator is running

The Bluetooth specification says that (when using legacy advertising) it is forbidden to update the random address whilst another role is running.
That means we can't start a scanner while an advertiser is running or the opposite.

With the resume feature, it is very probable that the host attempts to re-start advertising while the scanner is already running.

Proposed change

We should deprecate that feature.
It has also been the source of many race-condition bugs (finding PRs left as exercise to the reader).

With the addition of the recycled callback, that feature is now implementable by the application itself.

zephyr/include/zephyr/bluetooth/conn.h

Lines 1003 to 1016 in e32c2ee

    
           	/** @brief A connection object has been returned to the pool. 
        
           	 * 
        
           	 * This callback notifies the application that it might be able to 
        
           	 * allocate a connection object. No guarantee, first come, first serve. 
        
           	 * 
        
           	 * Use this to e.g. re-start connectable advertising or scanning. 
        
           	 * 
        
           	 * Treat this callback as an ISR, as it originates from 
        
           	 * @ref bt_conn_unref which is used by the BT stack. Making 
        
           	 * Bluetooth API calls in this context is error-prone and strongly 
        
           	 * discouraged. 
        
           	 */ 
        
           	void (*recycled)(void);

Additional context

The text was updated successfully, but these errors were encountered:

Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>

The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>

The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]> wip note: BT_LE_PER_ADV_DEFAULT

This test verifies a convoluted interaction between the scanner and the resumable advertiser feature in the host. That feature is going away, see zephyrproject-rtos#72567. Prepare that work by removing this test that's in the way. Signed-off-by: Jonathan Rico <[email protected]>

This test verifies a convoluted interaction between the scanner and the resumable advertiser feature in the host. That feature is going away, see #72567. Prepare that work by removing this test that's in the way. Signed-off-by: Jonathan Rico <[email protected]>

This test verifies a convoluted interaction between the scanner and the resumable advertiser feature in the host. That feature is going away, see zephyrproject-rtos#72567. Prepare that work by removing this test that's in the way. Signed-off-by: Jonathan Rico <[email protected]>

github-actions · 2024-07-14T00:31:28Z

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

This test verifies a convoluted interaction between the scanner and the resumable advertiser feature in the host. That feature is going away, see zephyrproject-rtos#72567. Prepare that work by removing this test that's in the way. Signed-off-by: Jonathan Rico <[email protected]>

This test verifies a convoluted interaction between the scanner and the resumable advertiser feature in the host. That feature is going away, see zephyrproject-rtos#72567. Prepare that work by removing this test that's in the way. (cherry picked from commit 3af358d) Original-Signed-off-by: Jonathan Rico <[email protected]> GitOrigin-RevId: 3af358d Change-Id: Ie87c2a9163f414eb7cd18e13593e4a28ef9a3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5680019 Tested-by: ChromeOS Prod (Robot) <[email protected]> Commit-Queue: Fabio Baltieri <[email protected]> Reviewed-by: Fabio Baltieri <[email protected]>

The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]> wip note: BT_LE_PER_ADV_DEFAULT

The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>

github-actions · 2024-09-28T00:32:33Z

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>

The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. (cherry picked from commit 8cfad44) Original-Resolves: zephyrproject-rtos/zephyr#72567 Original-Signed-off-by: Aleksander Wasaznik <[email protected]> GitOrigin-RevId: 8cfad44 Cr-Build-Id: 8734380568354140561 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8734380568354140561 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: I4fad8e35af2a49bdefdc13b2f99684325483a986 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5918818 Tested-by: ChromeOS Prod (Robot) <[email protected]> Tested-by: Jeremy Bettis <[email protected]> Reviewed-by: Jeremy Bettis <[email protected]>

The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>

The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. Resolves: zephyrproject-rtos/zephyr#72567 Signed-off-by: Aleksander Wasaznik <[email protected]> (cherry picked from commit 8cfad44) Signed-off-by: Sean Madigan <[email protected]>

jori-nordic added bug The issue is a bug, or the PR is fixing a bug area: Bluetooth Host labels May 10, 2024

jori-nordic self-assigned this May 10, 2024

henrikbrixandersen added the area: Bluetooth label May 10, 2024

alwa-nordic added a commit to alwa-nordic/zephyr that referenced this issue May 14, 2024

Bluetooth: Host: Wrn deprecated adv auto-resume

d8848be

Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>

aescolar added the priority: low Low impact/importance bug label May 14, 2024

alwa-nordic mentioned this issue May 15, 2024

Bluetooth: Host: Modularize bt_le_adv_resume #69464

Closed

4 tasks

alwa-nordic added a commit to alwa-nordic/zephyr that referenced this issue May 21, 2024

Bluetooth: Host: Wrn deprecated adv auto-resume

1c7f029

Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>

alwa-nordic added a commit to alwa-nordic/zephyr that referenced this issue May 27, 2024

Bluetooth: Host: Deprecate adv auto-resume

27b1587

Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>

alwa-nordic added a commit to alwa-nordic/zephyr that referenced this issue May 28, 2024

Bluetooth: Host: Deprecate adv auto-resume

3d2e49e

Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>

alwa-nordic mentioned this issue May 28, 2024

Bluetooth: Deprecate adv auto-resume #73395

Merged

jori-nordic mentioned this issue Jul 2, 2024

Bluetooth: remove host/adv/resume test #75313

Merged

github-actions bot added the Stale label Jul 14, 2024

github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2024

jori-nordic reopened this Jul 29, 2024

jori-nordic removed the Stale label Jul 29, 2024

github-actions bot added the Stale label Sep 28, 2024

carlescufi closed this as completed in #73395 Oct 8, 2024

carlescufi closed this as completed in 8cfad44 Oct 8, 2024

sean-madigan mentioned this issue Nov 20, 2024

[nrf fromtree] Bluetooth: Deprecate adv auto-resume nrfconnect/sdk-zephyr#2287

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bluetooth: Advertising resume functionality is broken #72567

Bluetooth: Advertising resume functionality is broken #72567

jori-nordic commented May 10, 2024 •

edited

Loading

github-actions bot commented Jul 14, 2024

github-actions bot commented Sep 28, 2024

Bluetooth: Advertising resume functionality is broken #72567

Bluetooth: Advertising resume functionality is broken #72567

Comments

jori-nordic commented May 10, 2024 • edited Loading

github-actions bot commented Jul 14, 2024

github-actions bot commented Sep 28, 2024

jori-nordic commented May 10, 2024 •

edited

Loading