Skip to content

[Backport v3.7.99-ncs1-branch] drivers: serial: nrfx_uarte: Legacy shim rework to support nrf54x and runtime device PM #7127

[Backport v3.7.99-ncs1-branch] drivers: serial: nrfx_uarte: Legacy shim rework to support nrf54x and runtime device PM

[Backport v3.7.99-ncs1-branch] drivers: serial: nrfx_uarte: Legacy shim rework to support nrf54x and runtime device PM #7127

Triggered via pull request October 28, 2024 11:45
Status Success
Total duration 2m 22s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 12s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

1 error, 1 warning, and 10 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR): ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#if (UARTE_FOR_EACH_INSTANCE(INSTANCE_PROP, (+), (0), frame_timeout_supported)) == \ +#if (UARTE_FOR_EACH_INSTANCE(INSTANCE_PROP, (+), (0), frame_timeout_supported)) == \ File:drivers/serial/uart_nrfx_uarte.c Line:94 You may want to run clang-format on this change: - uint32_t total_byte_cnt; /* Total number of bytes received */ + uint32_t total_byte_cnt; /* Total number of bytes received */ uint32_t total_user_byte_cnt; /* Total number of bytes passed to user */ - int32_t timeout_us; /* Timeout set by user */ - int32_t timeout_slab; /* rx_timeout divided by RX_TIMEOUT_DIV */ - int32_t timeout_left; /* Current time left until user callback */ + int32_t timeout_us; /* Timeout set by user */ + int32_t timeout_slab; /* rx_timeout divided by RX_TIMEOUT_DIV */ + int32_t timeout_left; /* Current time left until user callback */ File:drivers/serial/uart_nrfx_uarte.c Line:164 You may want to run clang-format on this change: -#define UARTE_FLAG_LOW_POWER (UARTE_FLAG_LOW_POWER_TX | UARTE_FLAG_LOW_POWER_RX) -#define UARTE_FLAG_TRIG_RXTO BIT(2) -#define UARTE_FLAG_POLL_OUT BIT(3) +#define UARTE_FLAG_LOW_POWER (UARTE_FLAG_LOW_POWER_TX | UARTE_FLAG_LOW_POWER_RX) +#define UARTE_FLAG_TRIG_RXTO BIT(2) +#define UARTE_FLAG_POLL_OUT BIT(3) /* If enabled then ENDTX is PPI'ed to TXSTOP */ -#define UARTE_CFG_FLAG_PPI_ENDTX BIT(0) +#define UARTE_CFG_FLAG_PPI_ENDTX BIT(0) /* If enabled then TIMER and PPI is used for byte counting. */ -#define UARTE_CFG_FLAG_HW_BYTE_COUNTING BIT(1) +#define UARTE_CFG_FLAG_HW_BYTE_COUNTING BIT(1) /* If enabled then UARTE peripheral is disabled when not used. This allows * to achieve lowest power consumption in idle. */ -#define UARTE_CFG_FLAG_LOW_POWER BIT(2) +#define UARTE_CFG_FLAG_LOW_POWER BIT(2) File:drivers/serial/uart_nrfx_uarte.c Line:236 You may want to run clang-format on this change: -#define LOW_POWER_ENABLED(_config) \ - (IS_ENABLED(UARTE_ANY_LOW_POWER) && \ - !IS_ENABLED(CONFIG_PM_DEVICE) && \ +#define LOW_POWER_ENABLED(_config) \ + (IS_ENABLED(UARTE_ANY_LOW_POWER) && !IS_ENABLED(CONFIG_PM_DEVICE) && \ File:drivers/serial/uart_nrfx_uarte.c Line:268 You may want to run clang-format on this change: - if (IS_ENABLED(CONFIG_PM_DEVICE_RUNTIME) && - (data->flags & UARTE_FLAG_POLL_OUT)) { + if (IS_ENABLED(CONFIG_PM_DEVICE_RUNTIME) && (data->flags & UARTE_FLAG_POLL_OUT)) { File:drivers/serial/uart_nrfx_uarte.c Line:353 You may want to run clang-format on this change: - - } - + } File:drivers/serial/uart_nrfx_uarte.c Line:385 You may want to run clang-format on this change: -#define HW_RX_COUNTING_ENABLED(config) \ - (IS_ENABLED(UARTE_ANY_HW_ASYNC) ? \ - (config->flags & UARTE_CFG_FLAG_HW_BYTE_COUNTING) : false) +#define HW_RX_COUNTING_ENABLED(config) \ + (IS_ENABLED(UARTE_ANY_HW_ASYNC) ? (config->flags & UARTE_CFG_FLAG_HW_BYTE_COUNTING) : false) File:drivers/serial/uart_nrfx_uarte.c Line:579 You may want to run clang-format on this change: - nrf_uarte_baudrate_set(uarte, - COND_CODE_1(CONFIG_UART_USE_RUNTIME_CONFIGURE, - (data->nrf_baudrate), (config->nrf_baudrate))); + nrf_uarte_baudrate_set(uarte, COND_CODE_1(CONFIG_UART_USE_RUNTIME_CONFIGURE, + (data->nrf_baudrate), (config->nrf_baudrate))); File:drivers/serial/uart_nrfx_uarte.c Line:592 You may want to run clang-format on this change: -static void timer_handler(nrf_timer_event_t event_type, void *p_context) { } +static void timer_handler(nrf_timer_event_t event_type, void *p_context) +{ +} File:drivers/serial/uart_nrfx_uarte.c Line:708 You may want to run clang-format on this change: - static const uint32_t rx_int_mask = - NRF_UARTE_INT_ENDRX_MASK | - NRF_UARTE_INT_RXSTARTED_MASK | - NRF_UARTE_INT_ERROR_MASK | - NRF_UARTE_INT_RXTO_MAS
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L94
drivers/serial/uart_nrfx_uarte.c:94 -#if (UARTE_FOR_EACH_INSTANCE(INSTANCE_PROP, (+), (0), frame_timeout_supported)) == \ +#if (UARTE_FOR_EACH_INSTANCE(INSTANCE_PROP, (+), (0), frame_timeout_supported)) == \
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L164
drivers/serial/uart_nrfx_uarte.c:164 - uint32_t total_byte_cnt; /* Total number of bytes received */ + uint32_t total_byte_cnt; /* Total number of bytes received */ uint32_t total_user_byte_cnt; /* Total number of bytes passed to user */ - int32_t timeout_us; /* Timeout set by user */ - int32_t timeout_slab; /* rx_timeout divided by RX_TIMEOUT_DIV */ - int32_t timeout_left; /* Current time left until user callback */ + int32_t timeout_us; /* Timeout set by user */ + int32_t timeout_slab; /* rx_timeout divided by RX_TIMEOUT_DIV */ + int32_t timeout_left; /* Current time left until user callback */
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L236
drivers/serial/uart_nrfx_uarte.c:236 -#define UARTE_FLAG_LOW_POWER (UARTE_FLAG_LOW_POWER_TX | UARTE_FLAG_LOW_POWER_RX) -#define UARTE_FLAG_TRIG_RXTO BIT(2) -#define UARTE_FLAG_POLL_OUT BIT(3) +#define UARTE_FLAG_LOW_POWER (UARTE_FLAG_LOW_POWER_TX | UARTE_FLAG_LOW_POWER_RX) +#define UARTE_FLAG_TRIG_RXTO BIT(2) +#define UARTE_FLAG_POLL_OUT BIT(3) /* If enabled then ENDTX is PPI'ed to TXSTOP */ -#define UARTE_CFG_FLAG_PPI_ENDTX BIT(0) +#define UARTE_CFG_FLAG_PPI_ENDTX BIT(0) /* If enabled then TIMER and PPI is used for byte counting. */ -#define UARTE_CFG_FLAG_HW_BYTE_COUNTING BIT(1) +#define UARTE_CFG_FLAG_HW_BYTE_COUNTING BIT(1) /* If enabled then UARTE peripheral is disabled when not used. This allows * to achieve lowest power consumption in idle. */ -#define UARTE_CFG_FLAG_LOW_POWER BIT(2) +#define UARTE_CFG_FLAG_LOW_POWER BIT(2)
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L268
drivers/serial/uart_nrfx_uarte.c:268 -#define LOW_POWER_ENABLED(_config) \ - (IS_ENABLED(UARTE_ANY_LOW_POWER) && \ - !IS_ENABLED(CONFIG_PM_DEVICE) && \ +#define LOW_POWER_ENABLED(_config) \ + (IS_ENABLED(UARTE_ANY_LOW_POWER) && !IS_ENABLED(CONFIG_PM_DEVICE) && \
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L353
drivers/serial/uart_nrfx_uarte.c:353 - if (IS_ENABLED(CONFIG_PM_DEVICE_RUNTIME) && - (data->flags & UARTE_FLAG_POLL_OUT)) { + if (IS_ENABLED(CONFIG_PM_DEVICE_RUNTIME) && (data->flags & UARTE_FLAG_POLL_OUT)) {
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L385
drivers/serial/uart_nrfx_uarte.c:385 - - } - + }
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L579
drivers/serial/uart_nrfx_uarte.c:579 -#define HW_RX_COUNTING_ENABLED(config) \ - (IS_ENABLED(UARTE_ANY_HW_ASYNC) ? \ - (config->flags & UARTE_CFG_FLAG_HW_BYTE_COUNTING) : false) +#define HW_RX_COUNTING_ENABLED(config) \ + (IS_ENABLED(UARTE_ANY_HW_ASYNC) ? (config->flags & UARTE_CFG_FLAG_HW_BYTE_COUNTING) : false)
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L592
drivers/serial/uart_nrfx_uarte.c:592 - nrf_uarte_baudrate_set(uarte, - COND_CODE_1(CONFIG_UART_USE_RUNTIME_CONFIGURE, - (data->nrf_baudrate), (config->nrf_baudrate))); + nrf_uarte_baudrate_set(uarte, COND_CODE_1(CONFIG_UART_USE_RUNTIME_CONFIGURE, + (data->nrf_baudrate), (config->nrf_baudrate)));
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L708
drivers/serial/uart_nrfx_uarte.c:708 -static void timer_handler(nrf_timer_event_t event_type, void *p_context) { } +static void timer_handler(nrf_timer_event_t event_type, void *p_context) +{ +}
You may want to run clang-format on this change: drivers/serial/uart_nrfx_uarte.c#L762
drivers/serial/uart_nrfx_uarte.c:762 - static const uint32_t rx_int_mask = - NRF_UARTE_INT_ENDRX_MASK | - NRF_UARTE_INT_RXSTARTED_MASK | - NRF_UARTE_INT_ERROR_MASK | - NRF_UARTE_INT_RXTO_MASK | - ((IS_ENABLED(CONFIG_UART_NRFX_UARTE_ENHANCED_RX) && - !IS_ENABLED(UARTE_HAS_FRAME_TIMEOUT)) ? NRF_UARTE_INT_RXDRDY_MASK : 0); + static const uint32_t rx_int_mask = NRF_UARTE_INT_ENDRX_MASK | + NRF_UARTE_INT_RXSTARTED_MASK | + NRF_UARTE_INT_ERROR_MASK | NRF_UARTE_INT_RXTO_MASK | + ((IS_ENABLED(CONFIG_UART_NRFX_UARTE_ENHANCED_RX) && + !IS_ENABLED(UARTE_HAS_FRAME_TIMEOUT)) + ? NRF_UARTE_INT_RXDRDY_MASK + : 0);

Artifacts

Produced during runtime
Name Size
compliance.xml
5.08 KB