Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: NOVU/FRAMEWORK ability to omit discovery result #6551

Open
2 tasks done
paulwer opened this issue Sep 23, 2024 · 4 comments
Open
2 tasks done

🚀 Feature: NOVU/FRAMEWORK ability to omit discovery result #6551

paulwer opened this issue Sep 23, 2024 · 4 comments

Comments

@paulwer
Copy link
Contributor

paulwer commented Sep 23, 2024

🔖 Feature description

We would like to use @novu/framework/express and currently the middleware will produce a console output for discovery the provided workflows.

🎤 Why is this feature needed ?

Outputs can get quite long and exspecial within production this can produce unwanted console logging garbage, so we would like to have an option to hide this output. f.ex. based on NODE_ENV.

✌️ How do you aim to achieve this?

A config object within serve() would be sufficient

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

Copy link

linear bot commented Sep 23, 2024

@jainpawan21
Copy link
Member

@paulwer Shared with team. Will keep you updated.

@paulwer
Copy link
Contributor Author

paulwer commented Nov 11, 2024

are there any updates on this topic?

@rifont
Copy link
Contributor

rifont commented Nov 13, 2024

Hey @paulwer , we are planning to rebuild logging in Framework and this will come with the capability to filter out logs for different Framework actions, including action=discover.

Another important part we will address is the capability to bring-your-own logger, so that logs appears in specified transport format.

@rifont rifont self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants