Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation about adding new icons #441

Open
guastallaigor opened this issue Oct 5, 2020 · 0 comments
Open

Update documentation about adding new icons #441

guastallaigor opened this issue Oct 5, 2020 · 0 comments
Labels
discussion Discussion of changes or bikeshedding documentation Adding, removing, or updating documentation

Comments

@guastallaigor
Copy link
Member

Is your feature request related to a problem? Please describe.
We are getting PRs about adding new icons, and we are not accepting those, because of the bundle size.

References:

Most contributors creates new PRs without opening issues first, which is unfortunate.

Describe the solution you'd like
Add a full section inside the README.md and / or CONTRIBUTION.md that specifically says: "We are not accepting PRs that adds new icons from the time being", or something like that.

Describe alternatives you've considered
We could also create a checklist in the PRs, similar to the other repos, that checks everything we are looking for in a PR, and one of those topics is something about this.

Or just inform the contributors on Gitter/Discord and only on open issues / PRs.

Additional context
Just see the PRs that are open and some of them closed regarding this issue.

@guastallaigor guastallaigor added documentation Adding, removing, or updating documentation discussion Discussion of changes or bikeshedding labels Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion of changes or bikeshedding documentation Adding, removing, or updating documentation
Projects
None yet
Development

No branches or pull requests

1 participant