From 241e100acf182933426f6261a5165e79db337d79 Mon Sep 17 00:00:00 2001 From: Arctic Ice Studio Date: Sun, 21 Jul 2019 08:46:01 +0200 Subject: [PATCH 1/5] Prepare and release version 0.11.0 --- CHANGELOG.md | 33 +++++++++++++++++++++++++++++++++ package-lock.json | 2 +- package.json | 2 +- 3 files changed, 35 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 95c348b..d5fd952 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,31 @@ +# 0.11.0 + +![Release Date: 2019-07-21](https://img.shields.io/static/v1.svg?style=flat-square&label=Release%20Date&message=2019-07-21&colorA=4c566a&colorB=88c0d0) [![Project Board](https://img.shields.io/static/v1.svg?style=flat-square&label=Project%20Board&message=0.11.0&colorA=4c566a&colorB=88c0d0)](https://github.com/arcticicestudio/nord-visual-studio-code/projects/20) [![Milestone](https://img.shields.io/static/v1.svg?style=flat-square&label=Milestone&message=0.11.0&colorA=4c566a&colorB=88c0d0)](https://github.com/arcticicestudio/nord-visual-studio-code/milestone/16) + +## Features + +**Indent guide lines in explorer tree view** — #145 ⇄ #147 (⊶ 54b6b205) by [@octref][gh-user-octref] +↠ Added the `tree.indentGuidesStroke` theme key introduced in [VS Code 1.36.0][vsc-rln-1.36] (June 2019) that adds [support for indent guide lines in the tree view][vsc-rln-1.36-igl]. To adapt to Nord's style and ensure it is still distinguishable from the background when hovering with the mouse, the new brightened comment color based on `nord3` ([GH-118][]) is used. + +

Before

+

+ +

After

+

+ +## Bug Fixes + +**Duplicate feature screenshot in README** — #141 (⊶ 994cae19) by [@chris78er][gh-user-chris78er] +↠ Renamed the invalid key `editorWidgetBorder` to the valid `editorWidget.border` key. + +### Documentation + +**Duplicate feature screenshot in README** — #140 (⊶ 46cce261) +↠ The second block in the [README's _Features_ section][gh-repo-readme#features] made use of the same screenshot two times like already used in the first block that has been fixed by adding and replacing the screenshot showing Go syntax instead. + # 0.10.0 ![Release Date: 2019-06-01](https://img.shields.io/badge/Release_Date-2019--06--01-88C0D0.svg?style=flat-square) [![Project Board](https://img.shields.io/badge/Project_Board-0.10.0-88C0D0.svg?style=flat-square)](https://github.com/arcticicestudio/nord-visual-studio-code/projects/19) [![Milestone](https://img.shields.io/badge/Milestone-0.10.0-88C0D0.svg?style=flat-square)](https://github.com/arcticicestudio/nord-visual-studio-code/milestone/15) @@ -757,6 +782,7 @@ Detailed information about features, supported languages and install instruction [ci-travis]: https://travis-ci.org [eslint-config-arcticicestudio-base]: https://www.npmjs.com/package/eslint-config-arcticicestudio-base [eslint]: https://eslint.org +[gh-118]: https://github.com/arcticicestudio/nord-visual-studio-code/issues/118 [gh-arcticicestudio/styleguide-git]: https://github.com/arcticicestudio/styleguide-git [gh-arcticicestudio/styleguide-javascript]: https://github.com/arcticicestudio/styleguide-javascript [gh-arcticicestudio/styleguide-markdown]: https://github.com/arcticicestudio/styleguide-markdown @@ -771,6 +797,7 @@ Detailed information about features, supported languages and install instruction [gh-husky]: https://github.com/typicode/husky [gh-lint-staged]: https://github.com/okonet/lint-staged [gh-remark-lint]: https://github.com/remarkjs/remark-lint +[gh-repo-readme#features]: https://github.com/arcticicestudio/nord-visual-studio-code#features [gh-user-gulshan]: https://github.com/gulshan [gh-user-kingdaro]: https://github.com/kingdaro [gh-user-lilyball]: https://github.com/lilyball @@ -840,3 +867,9 @@ Detailed information about features, supported languages and install instruction [nord-docs#149]: https://github.com/arcticicestudio/nord-docs/issues/149 + + + +[gh-user-chris78er]: https://github.com/chris78er +[vsc-rln-1.36-igl]: https://code.visualstudio.com/updates/v1_36#_tree-indent-guides +[vsc-rln-1.36]: https://code.visualstudio.com/updates/v1_36 diff --git a/package-lock.json b/package-lock.json index 56da959..3b3f153 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "nord-visual-studio-code", - "version": "0.10.0", + "version": "0.11.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index bf0ee55..ba6d9c1 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "nord-visual-studio-code", "displayName": "Nord", "description": "An arctic, north-bluish clean and elegant Visual Studio Code theme.", - "version": "0.10.0", + "version": "0.11.0", "publisher": "arcticicestudio", "author": { "name": "Arctic Ice Studio", From 4f808c88aa474f4d94a37e0b8f700bf33a395f7c Mon Sep 17 00:00:00 2001 From: Arctic Ice Studio Date: Sun, 21 Jul 2019 09:17:21 +0200 Subject: [PATCH 2/5] Rename theme file to enable theme development features An undocumented feature for theme extension developers is to ensure the name of the JSON file is suffixed with `-color-theme.json`. This enables the JSON scheme validation for the theme API allowing developers to validate the implemented theme keys, showing warnings about deprecated keys and providing full auto completion, field documentations and color previews (color picker) for the HEX format. This change aligns Nord to the official bundled and default themes (1) by adapting to the naming scheme without being a breaking change since the theme is identified by it's extension ID as well as the `_metadata` field in the `package.json` and not by the name of the theme file (which would be odd since a theme can provide multiple theme files). References: (1) https://github.com/microsoft/vscode/tree/master/extensions/theme-abyss/themes (2) https://github.com/svipas Extracted from GH-143 submitted by @svipas (2) Resolves GH-148 --- package.json | 2 +- themes/{nord.json => nord-color-theme.json} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename themes/{nord.json => nord-color-theme.json} (100%) diff --git a/package.json b/package.json index ba6d9c1..f45d21c 100644 --- a/package.json +++ b/package.json @@ -59,7 +59,7 @@ { "label": "Nord", "uiTheme": "vs-dark", - "path": "./themes/nord.json" + "path": "./themes/nord-color-theme.json" } ] }, diff --git a/themes/nord.json b/themes/nord-color-theme.json similarity index 100% rename from themes/nord.json rename to themes/nord-color-theme.json From 6b6655fc13752e4b6aa41ed4b8e5a86926f04752 Mon Sep 17 00:00:00 2001 From: Arctic Ice Studio Date: Sat, 10 Aug 2019 10:53:21 +0200 Subject: [PATCH 3/5] Minimap search results visibility (#152) In VS Code 1.37 (1) (July 2019) the search decorations in the minimap (code outline) have been improved so the entire line will now be highlighted with low opacity, and the actual match shown with high opacity. To customize the color the new `minimap.findMatchHighlight` UI/workbench theme key has been added to Nord. References: (1) https://code.visualstudio.com/updates/v1_37#_improved-minimap-search-results-visibility Resolves GH-150 --- themes/nord-color-theme.json | 1 + 1 file changed, 1 insertion(+) diff --git a/themes/nord-color-theme.json b/themes/nord-color-theme.json index 76a39b0..3f359bb 100644 --- a/themes/nord-color-theme.json +++ b/themes/nord-color-theme.json @@ -129,6 +129,7 @@ "merge.incomingHeaderBackground": "#8fbcbb66", "merge.incomingContentBackground": "#8fbcbb4d", "merge.border": "#3b425200", + "minimap.findMatchHighlight": "#88c0d0", /* `notification.*` keys are legacy support for VS Code versions >1.21.0 */ "notification.background": "#3b4252", From f5c767fdc0d0a2a47cca48addd31c3d7325fa89b Mon Sep 17 00:00:00 2001 From: Arctic Ice Studio Date: Sat, 10 Aug 2019 10:53:51 +0200 Subject: [PATCH 4/5] =?UTF-8?q?Filled=20background=20color=20for=20"Find"?= =?UTF-8?q?=20widget's=20button=20toggle=20active=E2=80=A6=20(#153)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In VS Code 1.37 (1) (July 2019) the Find widget's button toggle active state now has a filled background so that it is easier to tell when the focus is on an active toggle. To customize the background color of the toggle active state, the new `inputOption.activeBackground` UI/workbench theme key has been added to Nord. Unfortunately there is no UI theme key to also change the foreground color of active state toggles. It is "hard-coded" using a relatively bright color so it is not possible to also use a bright background color. It would be great to apply a "reverse" effect to e.g. use `nord0` as foreground to increase the contrast when using `nord8` as background color. References: (1) https://code.visualstudio.com/updates/v1_37#_button-toggle-active-state-in-find-widget Resolves GH-151 --- themes/nord-color-theme.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/themes/nord-color-theme.json b/themes/nord-color-theme.json index 3f359bb..59a1662 100644 --- a/themes/nord-color-theme.json +++ b/themes/nord-color-theme.json @@ -104,7 +104,8 @@ "input.foreground": "#d8dee9", "input.placeholderForeground": "#d8dee999", "input.border": "#3b4252", - "inputOption.activeBorder": "#88c0d0", + "inputOption.activeBackground": "#5e81ac", + "inputOption.activeBorder": "#5e81ac", "inputValidation.errorBackground": "#bf616a", "inputValidation.errorBorder": "#bf616a", "inputValidation.infoBackground": "#81a1c1", From b253a7f9d2d640bfa3937a07c4104b12a1f83419 Mon Sep 17 00:00:00 2001 From: Arctic Ice Studio Date: Sat, 10 Aug 2019 11:08:27 +0200 Subject: [PATCH 5/5] Prepare extension release version 0.12.0 --- CHANGELOG.md | 56 +++++++++++++++++++++++++++++++++++++++++------ package-lock.json | 2 +- package.json | 2 +- 3 files changed, 51 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d5fd952..5f9c859 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,42 @@

Changelog for Nord Visual Studio Code — An arctic, north-bluish clean and elegant Visual Studio Code theme.

- + + +# 0.12.0 + +![Release Date: 2019-08-10](https://img.shields.io/static/v1.svg?style=flat-square&label=Release%20Date&message=2019-08-10&colorA=4c566a&colorB=88c0d0) [![Project Board](https://img.shields.io/static/v1.svg?style=flat-square&label=Project%20Board&message=0.12.0&colorA=4c566a&colorB=88c0d0)](https://github.com/arcticicestudio/nord-visual-studio-code/projects/21) [![Milestone](https://img.shields.io/static/v1.svg?style=flat-square&label=Milestone&message=0.12.0&colorA=4c566a&colorB=88c0d0)](https://github.com/arcticicestudio/nord-visual-studio-code/milestone/17) + +## Features + +**Minimap search results visibility** — #150 ⇄ #152 (⊶ 6b6655fc) +↠ In [VS Code 1.37][vsc-rln-1.37#minimap_search_marker] (July 2019) the search decorations in the minimap (code outline) have been improved so the entire line will now be highlighted with low opacity, and the actual match shown with high opacity. +To customize the color, the new `minimap.findMatchHighlight` UI/workbench theme key has been added to Nord. + +

Before

+

+ +

After

+

+ +**Filled background color for „Find“ widget's button toggle active state** — #151 ⇄ #153 (⊶ f5c767fd) +↠ In [VS Code 1.37][vsc-rln-1.37#find_button_bg] (July 2019) the Find widget's button toggle active state now has a filled background so that it is easier to tell when the focus is on an active toggle. +To customize the background color of the toggle active state, the new `inputOption.activeBackground` UI/workbench theme key has been added to Nord. + +

Before

+

+ +

After

+

+

+ +Unfortunately there is no UI theme key (yet) to also change the foreground color of active state toggles. It is "hard-coded" using a relatively bright color so it is not possible to also use a bright background color. It would be great to apply a "reverse" effect to e.g. use `nord0` as foreground to increase the contrast when using `nord8` as background color. + +## Improvements + +**Renamed theme file to enable „hidden“ theme development features** — #143/#148 (⊶ 4f808c88) co-authored by [@svipas][gh-user-svipas] +↠ An undocumented feature for theme extension developers is to ensure the name of the JSON file is suffixed with `-color-theme.json`. This enables the JSON scheme validation for the theme API allowing developers to validate the implemented theme keys, showing warnings about deprecated keys and providing full auto completion, field documentations and color previews (color picker) for the HEX format. +By renaming the theme file, Nord aligns to the [official bundled and default themes][microsoft/vscode-tree-ext-theme-abyss] by adapting to the naming scheme without introducing a breaking change since the theme is identified by it's extension ID as well as the `_metadata` field in the `package.json` and not by the name of the theme file (which would be odd since a theme can provide multiple theme files). # 0.11.0 @@ -773,7 +808,7 @@ Detailed information about features, supported languages and install instruction ⊶ (U+22B6): Icon prefix for the short commit SHA checksum in a log metadata --> - + @@ -825,7 +860,7 @@ Detailed information about features, supported languages and install instruction [vscode-relnote-1.15-title-bar-border]: https://code.visualstudio.com/updates/v1_15#_new-theme-color-for-title-bar-border [vscode-relnote-1.16-theme-improv]: https://code.visualstudio.com/updates/v1_16#_theming-improvements - + [gh-100-c-fontc]: https://github.com/arcticicestudio/nord-visual-studio-code/issues/100#issuecomment-426005938 [vsc-rln-1.18-gitexp]: https://code.visualstudio.com/updates/v1_18#_git-status-in-file-explorer @@ -842,7 +877,7 @@ Detailed information about features, supported languages and install instruction [vsc-rln-1.24]: https://code.visualstudio.com/updates/v1_24 [vscode#178]: https://github.com/Microsoft/vscode/issues/178 - + [gh-microsoft/vscode#71663]: https://github.com/Microsoft/vscode/issues/71663 [gh-nord#94]: https://github.com/arcticicestudio/nord/issues/94 @@ -854,7 +889,7 @@ Detailed information about features, supported languages and install instruction [gh-user-sdr0x07b6]: https://github.com/sdr0x07b6 [gh-user-varog-norman]: https://github.com/varog-norman - + [circle-ci-doc-config]: https://circleci.com/docs/2.0/configuration-reference [gh-133]: https://github.com/arcticicestudio/nord-visual-studio-code/issues/133 @@ -864,12 +899,19 @@ Detailed information about features, supported languages and install instruction [gh-blog-intro-issue-templ]: https://blog.github.com/2016-02-17-issue-and-pull-request-templates [gh-blog-multi-issue-templ]: https://blog.github.com/2018-01-25-multiple-issue-and-pull-request-templates - + [nord-docs#149]: https://github.com/arcticicestudio/nord-docs/issues/149 - + [gh-user-chris78er]: https://github.com/chris78er [vsc-rln-1.36-igl]: https://code.visualstudio.com/updates/v1_36#_tree-indent-guides [vsc-rln-1.36]: https://code.visualstudio.com/updates/v1_36 + + + +[gh-user-svipas]: https://github.com/svipas +[microsoft/vscode-tree-ext-theme-abyss]: https://github.com/microsoft/vscode/tree/master/extensions/theme-abyss/themes +[vsc-rln-1.37#find_button_bg]: https://code.visualstudio.com/updates/v1_37#_button-toggle-active-state-in-find-widget +[vsc-rln-1.37#minimap_search_marker]: https://code.visualstudio.com/updates/v1_37#_improved-minimap-search-results-visibility diff --git a/package-lock.json b/package-lock.json index 3b3f153..e2a9207 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "nord-visual-studio-code", - "version": "0.11.0", + "version": "0.12.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index f45d21c..bc41852 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "nord-visual-studio-code", "displayName": "Nord", "description": "An arctic, north-bluish clean and elegant Visual Studio Code theme.", - "version": "0.11.0", + "version": "0.12.0", "publisher": "arcticicestudio", "author": { "name": "Arctic Ice Studio",