Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TypeScript vim/neovim #163

Open
asilvadesigns opened this issue May 30, 2019 · 10 comments
Open

Add support for TypeScript vim/neovim #163

asilvadesigns opened this issue May 30, 2019 · 10 comments

Comments

@asilvadesigns
Copy link

Hello,

I have certain values that I've added and modified via augroup nord-theme-overrides ... for TypeScript syntax via HerringtonDarkholme/yats.vim syntax plugin.

Is this something you would like a PR for?

Screenshot below:
Screen Shot 2019-05-30 at 3 04 34 PM

@asilvadesigns asilvadesigns changed the title Add support for TypeScript? Add support for TypeScript vim/neovim? May 30, 2019
@asilvadesigns asilvadesigns changed the title Add support for TypeScript vim/neovim? Add support for TypeScript vim/neovim May 30, 2019
@asilvadesigns
Copy link
Author

Additionally, I would love feedback/critique for these color choices and your vision for what they should be, thanks!

@arcticicestudio
Copy link
Contributor

Hi @asilvadesigns 👋, thanks for your contribution 👍

Any PR is always welcome and support for more plugins is good. I'd say it's easier to discuss about styles in a PR review than through a screenshot. Nord's docs about the color palettes includes some design principles and guidelines that can be used as a supportive resource to create a port and define syntax styles.

@asilvadesigns
Copy link
Author

Perfect! Thanks so much, I'll take a look and hopefully raise a PR within the next week.

BennyLi added a commit to BennyLi/dotfiles that referenced this issue Aug 23, 2019
* More language supports (plugins)
* More Typescript support
* Added coc.nvim for autocompletion and syntax checks
* Changed theme to iceberg as nord has a bug with Typescript (see nordtheme/vim#163)
* Some minor adjustments
@ramirezd42
Copy link

@asilvadesigns any update on this? at the very least could you share what you have? looks great :)

@PichardoWilfred
Copy link

This looks great how can i apply it?

@vincentmac
Copy link

This is exactly what i'm looking for. @asilvadesigns any bandwidth for this PR? My eyes would thank you! Typescript is still pretty busy looking in nord as it is right now.

@alexnix
Copy link

alexnix commented Nov 18, 2020

Hi,

I like nord.
Any plans to add suport for Typescript?

@robbienohra
Copy link

Bump

@jvoisin
Copy link
Contributor

jvoisin commented Apr 16, 2022

Typescript support was added in 1bd44ad

@svengreb
Copy link
Member

svengreb commented May 29, 2023

Thank you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added for triage in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.

@asilvadesigns Since there have been many changes in relation to JavaScript/TypeScript in the meantime, it would be great if you could see if the topic has been resolved in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: triage
Development

No branches or pull requests

9 participants