Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposition for a better annotate feature #158

Open
Tom1206 opened this issue May 24, 2020 · 5 comments
Open

Proposition for a better annotate feature #158

Tom1206 opened this issue May 24, 2020 · 5 comments

Comments

@Tom1206
Copy link

Tom1206 commented May 24, 2020

Hi,

I recently discovered in another theme the colour possibilities of the annotate feature in IntelliJ platform.

Currently Nord uses a single background colour, but I think this is a waste of a nice and convenient feature.

I tried two settings:

The first one, using nord7 to nord10, is quite colourful (maybe to much, but I kind of like it).
Screenshot 2020-05-24 at 23 03 44
Screenshot 2020-05-24 at 23 08 40

The colours allow to very quickly distinguish the more recent modifications from the older ones.

The second possibility is more tamed (using nord0 to nord3), and I think it's more in line with Nord in general, although a little less obvious when comparing old vs new commits.
Screenshot 2020-05-24 at 23 06 57
Screenshot 2020-05-24 at 23 07 24

IntelliJ offers up to 5 colours to create the gradient, but you can use less (I used 4 in these examples)

Let me know what you think.
I'm working on a pull request to fix a lot of small bug and missed colours throughout the theme, if you want I can include one of these propositions in.

I hope you are well in these difficult times, and as always I want to say thank you to the amazing work you are doing on Nord 💙.

@f1729
Copy link

f1729 commented May 27, 2020

That seems pretty nice!

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 4, 2020

Hi @Tom1206 👋, thanks for your contribution 👍

Sadly my free time is still really limited, but health is always most importantly and I'm fine. I hope everything is fine with you too.

Using the colors of the Frost palette looks really way better 😮
A darker color for changes that are further in the past and lighter colors for recent changes makes it really easy to find the information faster. Also nice you've also added Polar Night colors as alternatives, but I also guess this looks too subtle.

@Tom1206
Copy link
Author

Tom1206 commented Jun 4, 2020

Hi @arcticicestudio. Glad to know you're okay ☺️, I'm also fine.

As I said I'm working on a pull request to fix everything I can find to fix in Nord Jetbrains (don't worry I'm organising everything in commits, with long descriptive messages). I implemented the Polar Night version and was testing it for the last few days, it was nice. I really didn't thought you would prefer it with Frost (I prefer it too). I will implement it in a commit in my pull request if you want.

@shiveenp
Copy link

This is wonderful and would love to have it in the theme 👍

@KTibow
Copy link

KTibow commented May 13, 2023

Are you still working on this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants