Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger Menu in Default Theme Doesn't Toggle Menu #39

Open
freelancewebdev opened this issue Aug 11, 2017 · 5 comments
Open

Hamburger Menu in Default Theme Doesn't Toggle Menu #39

freelancewebdev opened this issue Aug 11, 2017 · 5 comments
Assignees
Milestone

Comments

@freelancewebdev
Copy link

When viewing the screens on a mobile device, the hamburger menu that should display a dropdown of the main menu elements does not display on the default theme. It works fine with the 'clean' theme but unfortunately that is not applied on the dashboard. There are no javascript errors.

EduTracSIS Release: 6.3.3
MySQL 5.7
PHP 7.1.4
Apache 2.24
MACOS Sierra

@nomadicjosh
Copy link
Owner

The hamburger in the dashboard should be taken out because the menus can appear without it. Can you not see or access the menus and the sidebar?

@freelancewebdev
Copy link
Author

I can.

Actually looking at the demo site it seems I was not accurate. The issue is more that if I hit the application on a mobile device, I can't log in because the login button isn't available - in the clean theme it shows when I hit the hamburger.

The reason I thought the hamburger wasn't working first was because in the demo you have some extra screens in the top menu and these correctly become collapsable on mobile.

This also affects the logged in user - on mobile devices they can't access the button to log out in the default theme and changing to the clean theme won't help because it's not used on the dashboard.

Hope that's clear.

@nomadicjosh
Copy link
Owner

Gotcha. The clean theme was created in hope people will use it because it fixes those issues in myetSIS.

Never really got that to work either in myetSIS or the dashboard with the default theme, probably because the Bootstrap is old. There is a plan to update the Bootstrap theme to see if that will fix the issue.

@freelancewebdev
Copy link
Author

For what it's worth, I much prefer the clean theme :)

@nomadicjosh nomadicjosh added this to the 7.0 milestone Jul 9, 2021
@nomadicjosh
Copy link
Owner

The Clean Theme will now be the default with other themes added as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants