-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support international utf-8 chars in param values / names #38
Comments
+1 why parameter values are not https://github.com/nodules/susanin/blob/master/lib/route.js#L76 |
As for me, using the XRegExp library as a general solution for the matching is not suitable for the router which targeted to be fast. On first sight the better solution is to provide interface to setup custom matching functions – then you can use whatever you want to match routes. |
By following rfc3986 the list of allowed characters in URI is this. I think there are three solutions:
What do you think, which one is better? |
Maybe for now we add basic support for cyrillic like this: var PARAM_VALUE_REGEXP_SOURCE = '[\\w\\-\\.~\u0400-\u04FF]+'; |
Hello!
international letter chars are not supported -
Using xregexp library (its unicode support - http://xregexp.com/plugins/#unicode) seems to be possible workaround.
The text was updated successfully, but these errors were encountered: